Skip to content

Commit

Permalink
qa: bump PHPUnit version
Browse files Browse the repository at this point in the history
PHPUnit 8.5 + Prophecy 1.8 was resulting in errors when lowest version was used, due to differences in how prophecy did type comparisons.
Bumping versions corrects the issues.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
  • Loading branch information
weierophinney committed Feb 10, 2021
1 parent 1408376 commit 3682715
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/EventManagerWithProviderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Laminas\EventManager\ListenerProvider\PrioritizedListenerAttachmentInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Prophecy\PhpUnit\ProphecyTrait;
use Psr\EventDispatcher\ListenerProviderInterface;

/**
Expand All @@ -21,6 +22,7 @@
class EventManagerWithProviderTest extends TestCase
{
use DeprecatedAssertions;
use ProphecyTrait;

public function testCanCreateInstanceWithListenerProvider()
{
Expand Down
3 changes: 3 additions & 0 deletions test/ListenerProvider/LazyListenerSubscriberTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,12 @@
use Laminas\EventManager\ListenerProvider\LazyListenerSubscriber;
use Laminas\EventManager\ListenerProvider\PrioritizedListenerAttachmentInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;

class LazyListenerAggregateTest extends TestCase
{
use ProphecyTrait;

public function setUp(): void
{
$this->container = $this->prophesize(ContainerInterface::class);
Expand Down
3 changes: 3 additions & 0 deletions test/ListenerProvider/LazyListenerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@
use Laminas\EventManager\Exception\InvalidArgumentException;
use Laminas\EventManager\ListenerProvider\LazyListener;
use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Psr\Container\ContainerInterface;

class LazyListenerTest extends TestCase
{
use ProphecyTrait;

public function setUp(): void
{
$this->container = $this->prophesize(ContainerInterface::class);
Expand Down
2 changes: 2 additions & 0 deletions test/ListenerProvider/ListenerSubscriberTraitTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@
use Laminas\EventManager\ListenerProvider\PrioritizedListenerAttachmentInterface;
use LaminasTest\EventManager\DeprecatedAssertions;
use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;

class ListenerSubscriberTraitTest extends TestCase
{
use DeprecatedAssertions;
use ProphecyTrait;

/**
* @return ListenerSubscriberInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,13 @@
use Laminas\EventManager\ListenerProvider\PrioritizedListenerProviderInterface;
use Laminas\EventManager\ListenerProvider\PrioritizedIdentifierListenerProvider;
use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Psr\EventDispatcher\ListenerProviderInterface;

class PrioritizedAggregateListenerProviderTest extends TestCase
{
use ProphecyTrait;

public function invalidProviders(): array
{
$genericProvider = $this->prophesize(ListenerProviderInterface::class)->reveal();
Expand Down

0 comments on commit 3682715

Please sign in to comment.