Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cookie parsing from headers in server request factory using globals. #193

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix cookie parsing from headers in server request factory using globals. #193

merged 2 commits into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Fix cookie header parsing for server request factory using globals 

    PHP used to encode space as '+' in the cookie header values in violation
of the RFC. This was fixed in PHP 7.4. See
https://bugs.php.net/bug.php?id=79174

Our cookie header parsing continued to decode '+' into space. This fix
brings our implementation back into alignment with the supported PHP
versions.

Signed-off-by: Aleksei Khudiakov <[email protected]>
    @Xerkus
    Xerkus committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1de1db6 View commit details
    Browse the repository at this point in the history

  2. Psalm fixes 

    Signed-off-by: Aleksei Khudiakov <[email protected]>
    @Xerkus
    Xerkus committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    949570d View commit details
    Browse the repository at this point in the history