Add support for PHP 8.4 #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
commented
Sep 4, 2024
cedric-anne
commented
| Q | A |
|---|---|
| Documentation | no |
| Bugfix | no |
| BC Break | no |
| New Feature | yes |
| RFC | no |
| QA | no |
cedric-anne
force-pushed
the
feature/php-8.4
branch
from
5e6913d
to
13e926f
Compare
|
There are the following deprecations triggered by any PHP command in the CI env itself: For instance, they are triggered inside the CI init process itself: I do not know how to fix them, and it makes the PHPUnit test failing. |
|
An upgrade to PHPUnit 10 is probably required - see #190 |
Honestly, I thought it would take me only a few minutes at first. I proposed this to be able to activate PHP 8.4 checks on the CI of a dependency of a dependency we use. Unfortunately, I will not have time to investigate more on this right now. |
Xerkus
force-pushed
the
feature/php-8.4
branch
from
13e926f
to
cd8e96a
Compare
Signed-off-by: Cédric Anne <[email protected]>
Signed-off-by: Cédric Anne <[email protected]>
Signed-off-by: Cédric Anne <[email protected]>
cedric-anne
force-pushed
the
feature/php-8.4
branch
from
f65a286
to
3e5d4da
Compare
|
I have no idea how to fix tests and no time to investigate on this. I close this PR as I am pretty sure I will not be able to finish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.