Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP constraints to allow v8.3 #176

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Oct 27, 2023

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC yes
QA no

Description

Refs #175

@ADmad
Copy link
Contributor Author

ADmad commented Oct 27, 2023

The "QA Checks' failure seems to be due to a bug in psalm which is addressed here vimeo/psalm#10186 but hasn't been released yet.

composer.lock Outdated Show resolved Hide resolved
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ADmad!

@Ocramius Ocramius merged commit 6584d44 into laminas:2.26.x Oct 29, 2023
13 checks passed
@ADmad
Copy link
Contributor Author

ADmad commented Oct 29, 2023

I reverted the changes and then ran compose update --lock, not sure why it downgraded the version for plugin-api-version.

@ADmad
Copy link
Contributor Author

ADmad commented Oct 29, 2023

I reverted the changes and then ran compose update --lock, not sure why it downgraded the version for plugin-api-version.

TIL: The value for plugin-api-version in composer.lock depends on the composer version used. I had used an older 2.0.4 version of composer hence plugin-api-version was set to 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants