Remove support for PHP 8.0, remove unnecessary reflection method calls #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Steel <[email protected]>
froschdesign
approved these changes
Oct 26, 2023
|
I don't think it's necessarily worth releasing this, what do you think? |
|
@gsteel |
|
I'm releasing this as-is: any further improvements can safely land in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just investigating upgrading to PHPUnit 10 here to find out that it's still blocked by the interop integration tests.
Considering that we'll be dropping 8.0 for PHPUnit 10 anyhow, this patch just chips off one job from that upgrade.