Fix stream metadata after detach

Signed-off-by: Aleksei Khudiakov <[email protected]>
laminas · Sep 10, 2024 · b270b28 · b270b28
1 parent 86a20b6
commit b270b28
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/Stream.php b/src/Stream.php
@@ -297,11 +297,15 @@ public function getContents(): string
      */
     public function getMetadata(?string $key = null)
     {
+        $metadata = [];
+        if (null !== $this->resource) {
+            $metadata = stream_get_meta_data($this->resource);
+        }
+
         if (null === $key) {
-            return stream_get_meta_data($this->resource);
+            return $metadata;
         }
 
-        $metadata = stream_get_meta_data($this->resource);
         if (! array_key_exists($key, $metadata)) {
             return null;
         }

diff --git a/test/StreamTest.php b/test/StreamTest.php
@@ -596,6 +596,16 @@ public function testGetMetadataReturnsAllMetadataWhenNoKeyPresent(): void
         $this->assertSame($expected, $test);
     }
 
+    public function testGetMetadataReturnsEmptyArrayAfterDetach(): void
+    {
+        self::assertNotEmpty($this->stream->getMetadata());
+        self::assertNotEmpty($this->stream->getMetadata('mode'));
+
+        $this->stream->detach();
+        self::assertSame([], $this->stream->getMetadata());
+        self::assertNull($this->stream->getMetadata('mode'));
+    }
+
     public function testGetMetadataReturnsDataForSpecifiedKey(): void
     {
         $this->tmpnam = tempnam(sys_get_temp_dir(), 'diac');