Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize composer version range #74

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Normalize composer version range #74

merged 1 commit into from
Jan 20, 2022

Conversation

ghostwriter
Copy link
Contributor

Q A
Bugfix yes

This patch resolves #73.

@ghostwriter
Normalize composer version range
9d9310d 
Signed-off-by: Nathanael Esayeas <[email protected]>
Ocramius
Ocramius approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO OK, but the fact that this repo has zero tests/quality checks (also acting as documentation) worries me quite a bit 😬

@weierophinney do we have a plan for this somewhere?

@Ocramius Ocramius added the Bug Something isn't working label Jan 20, 2022
@Ocramius Ocramius added this to the 1.11.5 milestone Jan 20, 2022
@Ocramius Ocramius self-assigned this Jan 20, 2022
@Ocramius Ocramius merged commit a380ce3 into laminas:1.11.x Jan 20, 2022
@github-actions github-actions bot mentioned this pull request Jan 20, 2022
Merged
@ghostwriter ghostwriter deleted the bugfix/normalize-composer-version branch January 20, 2022 03:25
@boesing
Copy link
Member

boesing commented Jan 20, 2022

@Ocramius I've started working on CI last year: #62
The main idea was to create a directory where "projects" can be created with specific "files" and with a matrix.json. This would enable us to create fake-projects with the exact outcome we expect when these are "parsed" by this container.

But sadly, I haven't written down that so that some1 else could take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working
Projects
None yet
Milestone
1.11.5
Development

Successfully merging this pull request may close these issues.
3 participants
@ghostwriter @boesing @Ocramius