Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/remove EOL PHP versions from matrix #196

Merged

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Mar 2, 2023

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA yes

Ref: laminas/laminas-continuous-integration-action#149

@Ocramius Ocramius force-pushed the cleanup/remove-eol-php-versions-from-matrix branch from 2b0c61d to afcb6fc Compare March 2, 2023 16:18
Copy link
Member

@internalsystemerror internalsystemerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping support in the next major version. No objections, I too like to \o/ burn all the things \o/ but what's the motivation? I know v1 will always be there, but is having these older versions around that much of a burden?

@Ocramius
Copy link
Member Author

Ocramius commented Mar 2, 2023

Main motivation is that packages upgrading to v2 now should also stop supporting PHP 7.

Secondary: reduce container size and clutter 👍

Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lcobucci lcobucci merged commit 753ed73 into laminas:2.0.x Mar 2, 2023
@Ocramius Ocramius deleted the cleanup/remove-eol-php-versions-from-matrix branch March 2, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants