Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from PHPDBG to just "PHP" for coverage and mutation tests #189

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Switch from PHPDBG to just "PHP" for coverage and mutation tests #189

merged 1 commit into from
Mar 2, 2023

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius added this to the 1.23.0 milestone Feb 22, 2023
@Ocramius Ocramius requested a review from gsteel February 22, 2023 10:38
@Ocramius Ocramius mentioned this pull request Feb 22, 2023
Open
1 task
@internalsystemerror
Copy link
Member

Changes look good, obv we need to get the checks green but I thought they would have been already? laminas/laminas-continuous-integration-action#148 shouldnt be needed for that?

@boesing
Copy link
Member

boesing commented Feb 22, 2023

I wonder if we should explicitly enable pcov extension for phpunit runs rather than having it enabled by-default.

I can't see anything related to pcov in this PR; how is it enabled?

@gsteel
Copy link
Member

gsteel commented Feb 22, 2023

I thought the CI failures were my fault, but it looks like a regression in sergeysova/[email protected] introduced here sergeysova/jq-action#9

See #190

@Ocramius
Copy link
Member Author

I can't see anything related to pcov in this PR; how is it enabled?

I'll run the built container and check: very good point!

@Ocramius Ocramius modified the milestones: 1.23.0, 2.0.0 Feb 22, 2023
@Ocramius
Copy link
Member Author

I'll merge this into 2.0.0 too.

@internalsystemerror
Copy link
Member

This might need rebasing, and then hopefully thanks to #191 the checks should be green. If not then something else has gone wrong here.

@Ocramius Ocramius mentioned this pull request Mar 2, 2023
Open
@Ocramius Ocramius force-pushed the feature/drop-phpdbg-for-pcov branch from 122a1df to fe26adc Compare March 2, 2023 15:28
@Ocramius Ocramius changed the base branch from 1.23.x to 2.0.x March 2, 2023 15:37
@Ocramius Ocramius self-assigned this Mar 2, 2023
@Ocramius Ocramius merged commit d8f024c into laminas:2.0.x Mar 2, 2023
@Ocramius Ocramius deleted the feature/drop-phpdbg-for-pcov branch March 2, 2023 15:38
Ocramius added a commit to bdsl/BackwardCompatibilityCheck that referenced this pull request May 22, 2024
@Ocramius
Reducing mutation testing requirements: makes CI green.
c245e9c 
Note that MT MSI is 100% when running with XDebug, but 85.84% when running with `phpdbg`, which is
no longer supported by PHPUnit.

This will be fixed in a later iteration of the Laminas test container: laminas/laminas-ci-matrix-action#189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@internalsystemerror internalsystemerror internalsystemerror approved these changes

@gsteel gsteel Awaiting requested review from gsteel

Assignees

@Ocramius Ocramius

Labels
BC Break Enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ocramius @internalsystemerror @boesing @gsteel