Skip to content

Commit

Permalink
bugfix: always store $resource in internal property cache
Browse files Browse the repository at this point in the history
Due to refactoring, the property reference was removed but the resource was only re-written to the propery cache when the version was not available. This is fixed with this commit.

Signed-off-by: Maximilian Bösing <[email protected]>
  • Loading branch information
boesing committed May 21, 2024
1 parent c3b71f5 commit b337de6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/RedisResourceManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ public function getResource($id)
$redis = $resource['resource'];

Check failure on line 176 in src/RedisResourceManager.php

View workflow job for this annotation

GitHub Actions / QA Checks (PHPCodeSniffer [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Equals sign not aligned with surrounding assignments; expected 15 spaces but found 16 spaces
$info = $this->getRedisInfo($redis);

Check failure on line 177 in src/RedisResourceManager.php

View workflow job for this annotation

GitHub Actions / QA Checks (PHPCodeSniffer [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Equals sign not aligned with surrounding assignments; expected 16 spaces but found 17 spaces
$resource['version'] = $info['redis_version'];

Check failure on line 178 in src/RedisResourceManager.php

View workflow job for this annotation

GitHub Actions / QA Checks (PHPCodeSniffer [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces
$this->resources[$id] = $resource;
unset($info);
}

$this->resources[$id] = $resource;
return $resource['resource'];
}

Expand Down

0 comments on commit b337de6

Please sign in to comment.