Merge pull request #84 from bcremer/sys_tmp_dir-fix

Ignore nonexistent system temporary directory when a valid cache directory is provided via options

src/FilesystemOptions.php

@@ -112,9 +112,11 @@ public function __construct($options = null)
             $this->dirPermission  = false;
         }
 
-        $this->setCacheDir(null);
-
         parent::__construct($options);
+
+        if ($this->cacheDir === null) {
+            $this->setCacheDir(null);
+        }
     }
 
     /**

test/unit/Filesystem/TestAsset/instantiate_filesystem_options_with_cache_dir.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+require_once dirname(__DIR__, 4) . '/vendor/autoload.php';
+use Laminas\Cache\Storage\Adapter\FilesystemOptions;
+
+$option = new FilesystemOptions(['cacheDir' => '/./tmp']);
+echo $option->getCacheDir();

test/unit/FilesystemOptionsTest.php

@@ -29,12 +29,15 @@
 use const DIRECTORY_SEPARATOR;
 use const PHP_EOL;
 use const PHP_OS;
+use const PHP_OS_FAMILY;
 
 /**
  * @template-extends AbstractAdapterOptionsTest<FilesystemOptions>
  */
 final class FilesystemOptionsTest extends AbstractAdapterOptionsTest
 {
+    private const MACOS_FAMILY = 'Darwin';
+
     /** @var string */
     protected $keyPattern = FilesystemOptions::KEY_PATTERN;
 
@@ -55,6 +58,12 @@ protected function createAdapterOptions(): AdapterOptions
         return new FilesystemOptions();
     }
 
+    public function testSetCacheDirToSystemsTempDirWhenNoCacheDirIsProvided(): void
+    {
+        $options = new FilesystemOptions();
+        self::assertEquals(realpath(sys_get_temp_dir()), $options->getCacheDir());
+    }
+
     public function testSetCacheDirToSystemsTempDirWithNull(): void
     {
         $this->options->setCacheDir(null);
@@ -230,4 +239,29 @@ public function testTagSuffixIsMutable(): void
         $this->options->setTagSuffix('.cache');
         self::assertSame('.cache', $this->options->getTagSuffix());
     }
+
+    /**
+     * The test asset script does provide a temporary directory and thus, the nonexistent system temp dir should
+     * not be used at all.
+     */
+    public function testFilesystemOptionsInstantiationWithNonExistentSystemTemporaryDirectory(): void
+    {
+        /**
+         * Due to the usage of `realpath` {@see FilesystemOptions::normalizeCacheDirectory()}, the directory is changed
+         * depending on the host system. As there might be developers using MacOS brew PHP to execute these tests, we
+         * allow MacOS `/private/tmp` as well.
+         */
+        $expectedTemporaryDirectory = match (PHP_OS_FAMILY) {
+            default => '/tmp',
+            self::MACOS_FAMILY => '/private/tmp',
+        };
+
+        $cacheDirectoryFromOptions = exec(
+            'TMPDIR=nonexistent php test/unit/Filesystem/TestAsset/instantiate_filesystem_options_with_cache_dir.php',
+            $output,
+            $exitCode,
+        );
+        self::assertSame(0, $exitCode);
+        self::assertSame($expectedTemporaryDirectory, $cacheDirectoryFromOptions);
+    }
 }