-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Current repository standards and configuration" section #13
Conversation
Signed-off-by: Sebastian Hopfe <[email protected]>
@@ -184,6 +185,12 @@ Once you know that your changes have been accepted to the canonical repository, | |||
```console | |||
$ git push fork :<branchname> | |||
``` | |||
## Current repository standards and configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which standards and which configuration do you have in mind here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change was suggested by ocramius because i asked for a place where you can find a current template for repo configurations. (https://laminas.slack.com/archives/C4R13GTRD/p1617030866068200)
It turned out that there is a corresponding repo that tries to keep it up to date. There you will find information on what coding standards, qa tool settings or the like have to be observed.
In order to document this for other contributors in the future, I have added this link to this file with a note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all fine but it doesn't answer the question: which standards and which configuration are meant here.
In other words, the following text is too general:
To get an overview of which current standards and configurations should be used for the components…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nusphere
Do you have time to update your pull request to clarify which standards and which configuration are meant here?
Thanks in advance! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tomorrow, i will give it a try to update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this should be closed,@nusphere.
It's been 3 years and no response. |
Description
this merge request adds information to the repository template in which configurations are kept up-to-date