Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Show data from DB #28

Closed
wants to merge 57 commits into from
Closed

Show data from DB #28

wants to merge 57 commits into from

Conversation

fkrause98
Copy link
Contributor

@fkrause98 fkrause98 commented Jul 10, 2023 •
edited
Loading

Changes:

  • Make the following pages use DB data (not everything is coming from the DB right now, however):
  1. Block Index.
  2. Block Detail.
  3. Transaction Detail.
  4. Transaction Index
  5. Index
  • Add "seeds" for development.

How to test:

  • Run the db dump with make seed and check the details and index pages.

fkrause98 and others added 26 commits July 4, 2023 18:57
@fkrause98
Add postgres yml file
09b3ed5
@fkrause98
Add draft GenServer and block migration
2e2cc32
@fkrause98
Add tx migration, schema and block schema
9765ea0
@fkrause98
Working commit
167f1ce
@fkrause98
Update blocks and transactions schemas
61acd85
@fkrause98
Use BlockFetcher only in Prod
ea80955
@fkrause98
Move block schema, update some fetcher code, mix format
3d5313a
@fkrause98
Update tx fields
6590ea9
@fkrause98
Lower fetch interval
0637600
@fkrause98
Mix format + update tx fields
42eef27
@fkrause98
Remove unnecesary comment
87eb1d2
@fkrause98
Add block fetcher tests
f05f03f
@fkrause98
Add postgres to CI job
f509beb
@fkrause98
Format
acc219a
@fkrause98
Add infura api key secret read
a7be459
@fkrause98
Undo wrong template change
9fdc79e
@fkrause98
Format
05d056a
@fkrause98
Update makefile and readme
39eaa51
@fkrause98
Fix CI
5568206
@fkrause98
Add seed
a4ec4a9
@fkrause98
Update block index to show DB data
b4b8593
@fkrause98
Make block fetching take transaction receipts
5f2d956
@fkrause98
Update function comment
cd52b81
@fkrause98
Merge branch 'main' into show-db-data
0426e62
@fkrause98
Add create-seed make target
cc28961
@fkrause98
Delete seed.sql
a26d3c7
@fkrause98 fkrause98 changed the title Show db data Fetch Transaction Receipts Jul 10, 2023
@fkrause98 fkrause98 changed the title Fetch Transaction Receipts Show data from DB Jul 10, 2023
@fkrause98 fkrause98 mentioned this pull request Jul 11, 2023
Merged
@fkrause98 fkrause98 marked this pull request as draft July 11, 2023 20:36
@fkrause98 fkrause98 marked this pull request as ready for review July 11, 2023 20:50
Base automatically changed from store-tx-receipts to main July 11, 2023 21:27
jrchatruc
jrchatruc reviewed Jul 11, 2023
View reviewed changes
lib/starknet_explorer_web/live/pages/home/index.ex Outdated
@@ -171,10 +171,12 @@ defmodule StarknetExplorerWeb.HomeLive.Index do

@impl true
def handle_info(:load_blocks, socket) do
[latest_block | blocks] = Block.latest_n_blocks_with_txs(15)
Copy link
Member

@jrchatruc jrchatruc Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should do something like

blocks = Block.latest_n_blocks_with_txs(15)
latest_block = List.first(blocks)

Otherwise the Html will render 14 blocks instead of 15 because the first one won't be included in the blocks list anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@fkrause98 fkrause98 marked this pull request as draft July 12, 2023 15:14
@fkrause98 fkrause98 marked this pull request as ready for review July 12, 2023 17:06
@fkrause98 fkrause98 marked this pull request as draft August 22, 2023 21:58
@fkrause98
Copy link
Contributor Author

Closing this in favor of #104

@fkrause98 fkrause98 closed this Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrchatruc jrchatruc jrchatruc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkrause98 @jrchatruc