add exercise #1
Open
add exercise #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAvecilla
reviewed
Mar 4, 2023
Comment on lines
+118
to
+124
| thread::sleep(time::Duration::from_secs(1)); | ||
|
|
||
| loop { | ||
| universe.tick(); | ||
| universe.draw_grid(); | ||
| next_frame().await; // // submit our render calls to our screen | ||
| thread::sleep(time::Duration::from_secs(1)); |
There was a problem hiding this comment.
This won't work with WASM because of the usage of thread::sleep.This is a good way to control the frames per second (FPS) running the app normally but fails to run in the browser. There is an issue on the macroquad lib asking how to achieve this compiling for WASM not-fl3/macroquad#380 (TLDR: there's a workaround but it's not supported on the lib). Right now it would be okay to allow the app runs freely without limiting the FPS when compiling for WASM. You can add #[cfg(not(target_arch = "wasm32"))] above both sleep calls to tell the compiler to execute that lines unless it's compiling for WASM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added my implementation of the exercise, although I am not sure the part with WebAssembly works fine.