-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uma opcodes #35
Uma opcodes #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's discuss the comments I've made before merging.
Great job with the generated tests and the feature.🚀
src/op_handlers/aux_heap_read.rs
Outdated
} | ||
let addr = src0.value.low_u32(); | ||
|
||
vm.current_frame.aux_heap.expand_memory(addr + 32); // TODO: Handle ergs cost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this with the new gas tracking changes? Or would it be too far fetched from the scope of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #12
This PR add the opcodes related to UMA,
ld, st, ld.1, ld.2, st.1, st.2
as well as.inc
variantsIt builds on top of #30 so that one needs to be merged first