-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mul and div opcodes #26
Merged
Merged
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9f7a812
impl mul
juan518munoz 0f03c65
add div
juan518munoz 9c84aa9
merge branch 'main'
juan518munoz fa70cc6
refactor makefile and programs dir
juan518munoz 56bf594
add missing flag for test
juan518munoz 6a463bd
merge branch 'main'
juan518munoz e39b8f5
add flag setting for mul
juan518munoz 7ffeace
fix mul not following spec
juan518munoz 30d6ed2
impl div set flags
juan518munoz e671111
div set flags test
juan518munoz acdfe78
more tests
juan518munoz 838ec36
clippy
juan518munoz 02ca9a9
add mul conditional test
juan518munoz 552140f
add div conditional tests
juan518munoz a5f9d4e
wrap address_operands
juan518munoz d328822
justify unwrap
juan518munoz d481767
Merge branch 'main' into mul-and-div-opcodes
juan518munoz 31f251c
remove makefile changes
juan518munoz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
programs/add_sets_overflow.zasm → programs/add/add_sets_overflow.zasm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
.text | ||
.file "add_sets_overflow.zasm" | ||
.file "mul_sets_overflow.zasm" | ||
.globl __entry | ||
__entry: | ||
|
||
|
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
.text | ||
.file "div_quotient.zasm" | ||
.file "div.zasm" | ||
.globl __entry | ||
__entry: | ||
.func_begin0: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
.text | ||
.file "div_codepage.zasm" | ||
.globl __entry | ||
|
||
.rodata | ||
datavar: | ||
.cell 42 | ||
.cell 3 | ||
.text | ||
|
||
__entry: | ||
.func_begin0: | ||
add 3, r0, r1 | ||
div @datavar[0], r1, r3, r4 | ||
sstore r0, r0 | ||
ret | ||
.func_end0: | ||
|
||
.note.GNU-stack | ||
.rodata |
4 changes: 2 additions & 2 deletions
4
programs/div/div_remainder.zasm → programs/div/div_conditional.zasm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
.text | ||
.file "div_conditional_gt.zasm" | ||
.globl __entry | ||
__entry: | ||
.func_begin0: | ||
add 1, r0, r3 | ||
add 1, r0, r4 | ||
add 42, r0, r1 | ||
add 3, r0, r2 | ||
div.gt r1, r2, r3, r4 | ||
sstore r0, r3 | ||
ret | ||
.func_end0: | ||
|
||
.note.GNU-stack | ||
.rodata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
.text | ||
.file "div_set_eq_flag.zasm" | ||
.globl __entry | ||
__entry: | ||
.func_begin0: | ||
; EQ is set if the quotient is not zero | ||
add 25, r0, r1 | ||
add 6, r0, r2 | ||
div! r1, r2, r3, r4 | ||
sstore r0, r3 | ||
ret | ||
.func_end0: | ||
|
||
.note.GNU-stack | ||
.rodata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
.text | ||
.file "div_set_gt_flag.zasm" | ||
.globl __entry | ||
__entry: | ||
.func_begin0: | ||
; GT is set if the reminder is not zero. | ||
add 25, r0, r1 | ||
add 6, r0, r2 | ||
div! r1, r2, r3, r4 | ||
sstore r0, r3 | ||
ret | ||
.func_end0: | ||
|
||
.note.GNU-stack | ||
.rodata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
.text | ||
.file "div_stack.zasm" | ||
.globl __entry | ||
__entry: | ||
|
||
.func_begin0: | ||
add 3, r0, r2 | ||
; grow stack | ||
add 1, r0, stack+=[1] | ||
; set stack values | ||
add 42, r0, stack=[0] | ||
; divide stack of absolute index 0 | ||
div stack=[0],r2, r3, r4 | ||
sstore r0, r0 | ||
ret | ||
|
||
.func_end0: | ||
.note.GNU-stack | ||
.rodata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ __entry: | |
.func_begin0: | ||
add 1, r0, r1 | ||
div r1, r0, r3, r4 | ||
sstore r0, r3 | ||
sstore r0, r0 | ||
ret | ||
.func_end0: | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
.text | ||
.file "mul_big.zasm" | ||
.globl __entry | ||
__entry: | ||
.func_begin0: | ||
; test sets r1 = 2**(256) - 1, r2 = 2**(256) | ||
mul r1, r2, r3, r4 | ||
sstore r0, r1 | ||
ret | ||
.func_end0: | ||
|
||
.note.GNU-stack | ||
.rodata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
.text | ||
.file "mul_codepage.zasm" | ||
.globl __entry | ||
|
||
.rodata | ||
datavar: | ||
.cell 42 | ||
.cell 3 | ||
.text | ||
|
||
__entry: | ||
.func_begin0: | ||
add 1, r0, r1 | ||
mul @datavar[0], r1, r1, r0 | ||
mul @datavar[1], r1, r1, r0 | ||
sstore r0, r1 | ||
ret | ||
.func_end0: | ||
|
||
.note.GNU-stack | ||
.rodata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
.text | ||
.file "mul_conditional_gt.zasm" | ||
.globl __entry | ||
__entry: | ||
.func_begin0: | ||
add 3, r0, r1 | ||
add 14, r0, r2 | ||
mul.gt r1, r2, r3, r4 | ||
sstore r0, r3 | ||
ret | ||
.func_end0: | ||
|
||
.note.GNU-stack | ||
.rodata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
.text | ||
.file "add_sets_overflow.zasm" | ||
.globl __entry | ||
__entry: | ||
|
||
.func_begin0: | ||
; test sets r1 = 2**(256) - 1, r2 = 2**(256) - 1 | ||
mul! r1, r2, r3, r4 | ||
sstore r0, r1 | ||
ret | ||
|
||
.func_end0: | ||
.note.GNU-stack | ||
.rodata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
.text | ||
.file "mul_stack.zasm" | ||
.globl __entry | ||
__entry: | ||
|
||
.func_begin0: | ||
add 1, r0, r2 | ||
; grow stack | ||
add 1, r0, stack+=[2] | ||
; set stack values | ||
add 2, r0, stack=[0] | ||
add 3, r0, stack=[1] | ||
; multiply by stack of absolute index 0 | ||
mul stack=[0],r2, r1, r0 | ||
; pop stack and multiply by the topmost value | ||
mul stack-=[2],r1, r1, r0 | ||
sstore r0, r1 | ||
ret | ||
|
||
.func_end0: | ||
.note.GNU-stack | ||
.rodata |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,17 @@ | ||
use crate::address_operands::address_operands_read; | ||
use crate::address_operands::{address_operands_read, address_operands_store}; | ||
use crate::{opcode::Opcode, state::VMState}; | ||
|
||
pub fn _div(vm: &mut VMState, opcode: Opcode) { | ||
let (src0, src1) = address_operands_read(vm, &opcode); | ||
vm.set_register(opcode.dst0_index, src0 / src1); | ||
vm.set_register(opcode.dst1_index, src0 % src1); | ||
pub fn _div(vm: &mut VMState, opcode: &Opcode) { | ||
let (src0, src1) = address_operands_read(vm, opcode); | ||
let (quotient, remainder) = src0.div_mod(src1); | ||
if opcode.alters_vm_flags { | ||
// Lt overflow is cleared | ||
vm.flag_lt_of = false; | ||
// Eq is set if quotient is not zero | ||
vm.flag_eq = !quotient.is_zero(); | ||
// Gt is set if the remainder is not zero | ||
vm.flag_gt = !remainder.is_zero(); | ||
} | ||
|
||
address_operands_store(vm, opcode, (quotient, Some(remainder))); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing an Option, wouldn't it be best to just have 2 functions, one for dst0 and the other for dst1, since the implementation is different.
I think this adds noise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a very special case, I think it's worth adding another implementation for div and mul, here's my proposal: