Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add predicates #22

Merged
merged 28 commits into from
Jun 13, 2024
Merged

Add predicates #22

merged 28 commits into from
Jun 13, 2024

Conversation

fkrause98
Copy link
Contributor

Changes:

  • Add state flags to the vm state.
  • Conditionally execute opcodes depending on instructions.
  • Add tests for features.

gianbelinche and others added 22 commits June 10, 2024 16:29
@gianbelinche
Add initial add opcode
e8ddeab
@gianbelinche
Begin operand indirection
dff174d
@jrchatruc
Merge branch 'main' into add-and-sub-opcodes
584d470
@gianbelinche
Add address for dest
15fe24a
@gianbelinche
Fix compilation error
fe606d4
@gianbelinche
Format code
faef779
@gianbelinche
Run clippy
0003e7c
@fkrause98
Add target for asm (#17)
3200c71 
* Add sub program

* Add 'add' program

* Update makefile with asm target

* Update test setup, add failing sub test and 'add' test

* Cargo fmt

* Remove echo

* Clippy
@fkrause98
Update test setup, add failing sub test and 'add' test
3ce70b1
@fkrause98
Remove echo
62221b2
@fkrause98
Clippy
bf908eb
@fkrause98
Add sub implementation
f39b2ba
@fkrause98
Make sub test work
10d9c81
@fkrause98
Add should be zero and modify simple test
c1f9203
@fkrause98
Modify tests
ff7437d
@fkrause98
Format
8b8e7c2
@fkrause98
Working tests
25f4462
@fkrause98
Lint
2dc13c1
@fkrause98
Add tests for conditional predicates
c77db08
@fkrause98
Explicitly add flags for vm state.
6bea502
@fkrause98
Add tests for predicates
4b0e40f
@fkrause98
Add failing test
960d16d
@fkrause98 fkrause98 marked this pull request as draft June 12, 2024 22:55
@fkrause98 fkrause98 changed the base branch from main to add-and-sub-opcodes June 12, 2024 22:57
@fkrause98 fkrause98 changed the base branch from add-and-sub-opcodes to main June 12, 2024 22:57
@fkrause98 fkrause98 marked this pull request as ready for review June 12, 2024 22:59
gianbelinche
gianbelinche requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one comment, everything else is fine

juan518munoz
juan518munoz approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fkrause98 fkrause98 merged commit eac3375 into main Jun 13, 2024
3 checks passed
@fkrause98 fkrause98 deleted the add-predicates branch June 13, 2024 18:34
@fkrause98 fkrause98 mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan518munoz juan518munoz juan518munoz approved these changes

@gianbelinche gianbelinche gianbelinche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fkrause98 @gianbelinche @juan518munoz @jrchatruc