Move benchmark contracts to era_vm #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ergs comparison results: |
Oppen
reviewed
Aug 29, 2024
| @@ -84,6 +84,9 @@ bench-setup: submodules build_bench_contracts $(ZKSYNC_BENCH_TEST_DATA) $(ZKSYNC | |||
| bench: | |||
| cd $(ZKSYNC_ROOT) && cargo bench --bench criterion "$(lambda|fast_vm|legacy)/(fibonacci|send)" | |||
|
|
|||
| check-flamegraph: | |||
| cd $(ZKSYNC_ROOT) && CARGO_PROFILE_BENCH_DEBUG=2 cargo flamegraph --root --bench criterion -- --bench --profile-time 5 "$lambda/fibonacci_rec^" | |||
There was a problem hiding this comment.
I think the $lambda is converted to ambda for some reason. What does $l do here? Is the $ even necessary?
There was a problem hiding this comment.
No, it is not necessary actually. I had been using it without any problems though, so I think it works ok.
Oppen
reviewed
Aug 29, 2024
Comment on lines
+14
to
+30
| def parse_benchmark_file(file_path): | ||
| machines = {} | ||
| pattern = r'(\w+)/\w+\s+time:\s+\[\d+(?:\.\d+)?\s(\w+)\s(\d+(?:\.\d+)?)\s(\w+)\s\d+(?:\.\d+)?\s(\w+)\]' | ||
|
|
||
| with open(file_path, 'r') as file: | ||
| content = file.read() | ||
| # Clean the file content | ||
| cleaned_content = re.sub(r'\n(\s+)time:', ' time:', content) | ||
| for line in cleaned_content.split('\n'): | ||
| match = re.match(pattern, line) | ||
| if match: | ||
| machine, lower_unit, mid_time, mid_unit, upper_unit = match.groups() | ||
| # Convert mid_time to milliseconds | ||
| mid_time_ms = convert_to_ms(float(mid_time), mid_unit) | ||
| machines[machine] = machines.get(machine, 0) + mid_time_ms | ||
|
|
||
| return machines |
There was a problem hiding this comment.
criterion is capable of emitting JSON IIRC. Maybe that could save you parsing.
There was a problem hiding this comment.
I didn't know that, it might be useful to improve the script. Thanks!
Oppen
approved these changes
Aug 29, 2024
|
Just to make sure, we should check the generated assembly for the contracts to confirm they do what we think they do. |
|
LGTM |
fkrause98
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves custom made benchmark contracts sources from zksync-era to era_vm, so its easier to modify them.
It also adds a new benchmark result processing script made in python, which allows us to easily aggregate all benchmark execution times.