Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: era_vm + zksync era #204

Merged
merged 27 commits into from
Aug 19, 2024
Merged

Tests: era_vm + zksync era #204

merged 27 commits into from
Aug 19, 2024

Conversation

fkrause98
Copy link
Contributor

Changes:

  • Add CI to run zksync-era's test suite.

Comment on lines +475 to +478
mkdir -p ./volumes/reth/data
mkdir -p ./volumes/postgres
docker compose -v up -d
sleep 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't zk init handle these by itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't working on the ci 🤷

Copy link
Contributor

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted that testing with zksync era makes use of the ZKSYNC_HOME env bar. Running zk & zk init previously is needed when testing locally.

@fkrause98 fkrause98 merged commit c1c1d2e into main Aug 19, 2024
184 checks passed
@fkrause98 fkrause98 deleted the tests/zksync-era branch August 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants