Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] fix typo #1977

Closed
wants to merge 1 commit into from
Closed

[DNM] fix typo #1977

wants to merge 1 commit into from

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Feb 26, 2025

TITLE

Description

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@FrancoGiachetta FrancoGiachetta added the documentation Improvements or additions to documentation label Feb 26, 2025
@FrancoGiachetta
Copy link
Contributor Author

The purpose of this PR was just to check if the ci was working

Copy link

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.871 s ±  0.068 s    [User: 26.077 s, System: 0.792 s]
  Range (min … max):   26.822 s … 26.919 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     27.003 s ±  0.147 s    [User: 26.225 s, System: 0.776 s]
  Range (min … max):   26.899 s … 27.107 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.796 s ±  0.013 s    [User: 25.954 s, System: 0.804 s]
  Range (min … max):   14.787 s … 14.805 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.777 s ±  0.050 s    [User: 25.979 s, System: 0.790 s]
  Range (min … max):   14.742 s … 14.812 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.661 s ±  0.168 s    [User: 39.245 s, System: 0.976 s]
  Range (min … max):   10.542 s … 10.779 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.956 s ±  0.386 s    [User: 39.407 s, System: 0.966 s]
  Range (min … max):   10.683 s … 11.229 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.03 ± 0.04 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.637 s ±  0.187 s    [User: 39.931 s, System: 0.951 s]
  Range (min … max):   10.505 s … 10.769 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.845 s ±  0.018 s    [User: 39.480 s, System: 0.972 s]
  Range (min … max):   10.832 s … 10.858 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.815 s ±  0.530 s    [User: 39.798 s, System: 0.969 s]
  Range (min … max):   10.440 s … 11.189 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.844 s ±  0.210 s    [User: 39.776 s, System: 0.987 s]
  Range (min … max):   10.696 s … 10.993 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.00 ± 0.05 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.752 s ±  0.309 s    [User: 40.194 s, System: 1.105 s]
  Range (min … max):   10.533 s … 10.970 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.533 s ±  0.013 s    [User: 40.112 s, System: 1.096 s]
  Range (min … max):   10.523 s … 10.542 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.02 ± 0.03 times faster than hyper_threading_main threads: 16


@gabrielbosio gabrielbosio changed the title fix typo [DNM] fix typo Feb 26, 2025
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.211 ± 0.014 2.190 2.229 1.01 ± 0.01
head big_factorial 2.195 ± 0.017 2.178 2.233 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.122 ± 0.016 2.106 2.157 1.00
head big_fibonacci 2.123 ± 0.020 2.104 2.163 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.895 ± 0.089 7.792 8.026 1.00
head blake2s_integration_benchmark 7.899 ± 0.148 7.773 8.211 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.262 ± 0.025 2.233 2.318 1.00
head compare_arrays_200000 2.273 ± 0.038 2.232 2.326 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.494 ± 0.012 1.470 1.506 1.00 ± 0.01
head dict_integration_benchmark 1.490 ± 0.017 1.468 1.527 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.251 ± 0.010 1.238 1.267 1.00
head field_arithmetic_get_square_benchmark 1.255 ± 0.022 1.232 1.305 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.954 ± 0.127 7.860 8.283 1.00 ± 0.02
head integration_builtins 7.944 ± 0.055 7.877 8.038 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.324 ± 0.162 8.158 8.689 1.01 ± 0.02
head keccak_integration_benchmark 8.279 ± 0.079 8.132 8.391 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.270 ± 0.028 2.215 2.326 1.00
head linear_search 2.271 ± 0.054 2.232 2.371 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.584 ± 0.011 1.570 1.603 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.577 ± 0.012 1.559 1.597 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.532 ± 0.007 1.518 1.539 1.01 ± 0.01
head math_integration_benchmark 1.519 ± 0.011 1.505 1.534 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.265 ± 0.016 1.250 1.295 1.00 ± 0.01
head memory_integration_benchmark 1.262 ± 0.008 1.253 1.277 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.639 ± 0.019 1.618 1.672 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.634 ± 0.010 1.618 1.652 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 546.6 ± 2.2 542.9 549.5 1.00 ± 0.01
head pedersen 544.1 ± 2.3 541.1 547.6 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 659.6 ± 7.7 651.1 676.3 1.01 ± 0.01
head poseidon_integration_benchmark 654.7 ± 4.8 649.7 664.1 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.903 ± 0.010 1.889 1.921 1.00
head secp_integration_benchmark 1.906 ± 0.009 1.897 1.923 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 688.3 ± 5.5 682.6 701.6 1.00
head set_integration_benchmark 688.8 ± 5.0 683.0 699.9 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.424 ± 0.047 4.383 4.540 1.01 ± 0.01
head uint256_integration_benchmark 4.394 ± 0.032 4.331 4.431 1.00

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (ed94d8c) to head (7c80981).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1977   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         103      103           
  Lines       42512    42512           
=======================================
  Hits        41010    41010           
  Misses       1502     1502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant