Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cairo-lang to 0.13.4a1 #1959

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Bump cairo-lang to 0.13.4a1 #1959

wants to merge 4 commits into from

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Feb 17, 2025

Bump cairo-lang to 0.13.4a1

Also changes a hint, to match the changes in 0.13.4a1

Copy link

github-actions bot commented Feb 17, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     27.307 s ±  0.058 s    [User: 26.540 s, System: 0.764 s]
  Range (min … max):   27.266 s … 27.348 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     27.385 s ±  0.086 s    [User: 26.617 s, System: 0.766 s]
  Range (min … max):   27.324 s … 27.446 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     15.203 s ±  0.036 s    [User: 26.737 s, System: 0.762 s]
  Range (min … max):   15.177 s … 15.228 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     15.163 s ±  0.004 s    [User: 26.648 s, System: 0.751 s]
  Range (min … max):   15.160 s … 15.165 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     11.404 s ±  0.113 s    [User: 39.375 s, System: 0.917 s]
  Range (min … max):   11.324 s … 11.484 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.123 s ±  0.463 s    [User: 39.729 s, System: 0.909 s]
  Range (min … max):   10.796 s … 11.450 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.03 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.943 s ±  0.036 s    [User: 39.359 s, System: 0.944 s]
  Range (min … max):   10.918 s … 10.969 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.868 s ±  0.026 s    [User: 40.315 s, System: 0.954 s]
  Range (min … max):   10.849 s … 10.886 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.01 ± 0.00 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.837 s ±  0.175 s    [User: 40.261 s, System: 0.924 s]
  Range (min … max):   10.713 s … 10.961 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.791 s ±  0.007 s    [User: 40.303 s, System: 0.937 s]
  Range (min … max):   10.786 s … 10.796 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.00 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.779 s ±  0.188 s    [User: 40.483 s, System: 1.022 s]
  Range (min … max):   10.647 s … 10.912 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.877 s ±  0.219 s    [User: 40.668 s, System: 1.014 s]
  Range (min … max):   10.721 s … 11.032 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 16


Copy link

github-actions bot commented Feb 17, 2025

Benchmark Results for modified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
head big_factorial 2.242 ± 0.036 2.208 2.322 1.00
Command Mean [s] Min [s] Max [s] Relative
head big_fibonacci 2.197 ± 0.020 2.179 2.243 1.00
Command Mean [s] Min [s] Max [s] Relative
head blake2s_integration_benchmark 8.298 ± 0.076 8.166 8.377 1.00
Command Mean [s] Min [s] Max [s] Relative
head compare_arrays_200000 2.347 ± 0.039 2.301 2.432 1.00
Command Mean [s] Min [s] Max [s] Relative
head dict_integration_benchmark 1.517 ± 0.014 1.502 1.553 1.00
Command Mean [s] Min [s] Max [s] Relative
head field_arithmetic_get_square_benchmark 1.304 ± 0.012 1.282 1.331 1.00
Command Mean [s] Min [s] Max [s] Relative
head integration_builtins 8.337 ± 0.083 8.204 8.502 1.00
Command Mean [s] Min [s] Max [s] Relative
head keccak_integration_benchmark 8.628 ± 0.063 8.458 8.669 1.00
Command Mean [s] Min [s] Max [s] Relative
head linear_search 2.338 ± 0.026 2.307 2.398 1.00
Command Mean [s] Min [s] Max [s] Relative
head math_cmp_and_pow_integration_benchmark 1.619 ± 0.021 1.593 1.659 1.00
Command Mean [s] Min [s] Max [s] Relative
head math_integration_benchmark 1.557 ± 0.013 1.539 1.578 1.00
Command Mean [s] Min [s] Max [s] Relative
head memory_integration_benchmark 1.295 ± 0.010 1.282 1.316 1.00
Command Mean [s] Min [s] Max [s] Relative
head operations_with_data_structures_benchmarks 1.668 ± 0.008 1.655 1.685 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
head pedersen 550.3 ± 2.0 547.3 553.6 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
head poseidon_integration_benchmark 655.8 ± 6.2 646.6 666.1 1.00
Command Mean [s] Min [s] Max [s] Relative
head secp_integration_benchmark 1.928 ± 0.020 1.900 1.973 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
head set_integration_benchmark 650.9 ± 4.9 644.8 660.3 1.00
Command Mean [s] Min [s] Max [s] Relative
head uint256_integration_benchmark 4.552 ± 0.027 4.511 4.596 1.00

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 96.36%. Comparing base (7a97bed) to head (da3073d).

Files with missing lines Patch % Lines
...int_processor/builtin_hint_processor_definition.rs 11.76% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1959      +/-   ##
==========================================
- Coverage   96.39%   96.36%   -0.04%     
==========================================
  Files         102      102              
  Lines       41566    41583      +17     
==========================================
+ Hits        40068    40070       +2     
- Misses       1498     1513      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabrielbosio gabrielbosio mentioned this pull request Feb 21, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant