Bug1794213 server keygen enroll input output #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate Signed-off-by: Dinesh Prasanth M K <[email protected]>
This patch: - Uses javascript to fill up the web UI request for ServerSide Keygen request profile - Provides 2 drop down boxes: KeyType and Keysize. KeySize autoupdates based on the KeyType selected. Example: RSA -> 1024, 2048,.. ; ECC -> nistp521, nistp256 - The keyType and keySize are read from the profile's attr: policyset.userCertSet.3.constraint.params.keyParameters File wise changes: - ServerKeygenUserKeyDefault.java can now generate Key pair based on the user's selection. (NOTE: This logic was added as a place holder. This might need some review) - ServerKeygenInput.java sends 2 new fields (keyType and keyRequest) to the request, to be displayed on the webUI - ProfileSelect.template carries the javascript changes. Note that there are 2 new if conditions included: "server_side_keygen_key_type" and "server_side_keygen_key_size". This ensures that it doesn't meddle with other profile web UIs - IDescriptor.java and UserMessages.properties carry the appropriate String values to be displayed/requested from user. Signed-off-by: Dinesh Prasanth M K <[email protected]>
|
This patch is overridden by #2 Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch carries the following changes:
Uses javascript to fill up the web UI request for ServerSide Keygen request profile
Provides 2 drop down boxes: KeyType and Keysize. KeySize autoupdates based on
the KeyType selected. Example: RSA -> 1024, 2048,.. ; ECC -> nistp521, nistp256
The keyType and keySize are read from the profile's attr:
policyset.userCertSet.3.constraint.params.keyParametersFile wise changes:
ServerKeygenUserKeyDefault.javacan now generate Key pair based on the user'sselection. (NOTE: This logic was added as a place holder. This might need some review)
ServerKeygenInput.javasends 2 new fields (keyType and keyRequest) to the request, to bedisplayed on the webUI
ProfileSelect.templatecarries the javascript changes. Note that there are 2 new ifconditions included: "server_side_keygen_key_type" and "server_side_keygen_key_size".
This ensures that it doesn't meddle with other profile web UIs
IDescriptor.javaandUserMessages.propertiescarry the appropriate String values tobe displayed/requested from user.
Testing procedure:
Following are the steps I personally used to test my changes:
Visit the webUI and choose "Certificate Profile - Manual User Dual-Use Certificate Enrollment using server-side Key generation"
Choose the appropriate inputs. (I also chose different set of KeyType and KeySize and verified that it gets logged in debug log)
Approve cert as caadmin
Certificate is generated: