-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BijectiveDictionaryBenchmark #22
base: main
Are you sure you want to change the base?
Conversation
bDict[left: element.left] = element.right | ||
} | ||
return bDict | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions are now written directly inline in the benchmark tests to improve readability.
Discovery: In the standard library, One thing I noticed is that they use (You don't want to inline your benchmark tests because you want to guarantee that the compiler isn't artificially skewing your results by optimizing it.) |
I absolutely agree. The goal of benchmarking should be to understand and quantify the overhead I think we should first implement and test all key features, reaching feature parity with |
Yes, it looks like this is covered by the |
This PR adds benchmark testing using https://github.com/apple/swift-collections-benchmark/tree/main
Resolves issue #14
Context
Helpful resources:
Usage
To run benchmarks you can use:
To chart benchmarks you can use:
For more info see: https://github.com/apple/swift-collections-benchmark/blob/main/Documentation/01%20Getting%20Started.md#running-benchmarks
Request For Comment
Dictionary
. This can help us internally, as well as inform users of performance tradeoffs.Room For Further Improvement
Note
swiftLanguageVersions
is deprecated in Package.swift after Swift 6. We should useswiftLanguageModes
instead.