-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the config from hypen to camel casing format for yaml #195
Conversation
Signed-off-by: Hemanth Gokavarapu <[email protected]>
@@ -1,4 +1,5 @@ | |||
default: | |||
sca: | |||
enable-dynamic: true | |||
enable-fast: true | |||
scan: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we can probably delete this file instead of changing the format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is not being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are used for the e2e tests. What happens if you delete this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about the repo, I can delete and try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it is not for the tests but the repo uses it to run those checks in github action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you added it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did but back then FAST was not enabled by default. I do not know about dynamic, maybe we need to keep this one. Are the corresponding triggered by these changes?
closing this PR as the config is already deleted. |
Signed-off-by: Hemanth Gokavarapu [email protected]
Jira
https://lacework.atlassian.net/browse/COD-3829
Description