using echo.AcquireContext

[poteto0]

CHANGE

use method, echo.AcqurireContext which defined.

-func (e *Echo) AcquireContext() Context {
-	return e.pool.Get().(Context)
+func (e *Echo) AcquireContext() *context {
+     return e.pool.Get().(*context)
}

func (e *Echo) ServeHTTP(w http.ResponseWriter, r *http.Request) {
	// Acquire context
-       c := e.pool.Get().(*context)
+	c := e.AcquireContext()
        ....
        // Release context
-	e.pool.Put(c)
+	e.ReleaseContext(c)
}

[aldas]

This is a API breaking change. Echo core tries to adhere to semantic versioning and doing major version bump for this is a little to much to ask.

[poteto0]

Q. What is the difference between returning interface and pointer -> struct?
or changing as below is destructive?

func (e *Echo) AcquireContext() Context {
	return e.pool.Get().(Context)
}

func (e *Echo) ServeHTTP(w http.ResponseWriter, r *http.Request) {
	// Acquire context
-       c := e.pool.Get().(*context)
+	c := e.AcquireContext().(*context)
        ....
        // Release context
-	e.pool.Put(c)
+	e.ReleaseContext(c)
}

Or It means "Changes" too small to increase version, dosen't it?

[aldas]

You can assign *echo.context to echo.Context because that struct satisfies that interface. but AcquireContext is a public method than anyone can use and now changing it would/could make their code do not compile anymore because you can not assign other structs (like you own custom context implementation) to that struct (*echo.context)

	c := e.AcquireContext()
	e.ReleaseContext(c)
	c = new(MyCustomContext) // Cannot use 'new(MyCustomContext)' (type *MyCustomContext) as the type *context

Yes, this is hypotetical but it still breaks library user code, it does not compile even anymore

[poteto0]

I see, I understand it well. Thank you very much.
I changed not to affect public method.