Add handling for empty content type in request header #2433
Conversation
|
so i was trying to build a rest api with echo and i did not know that i should set the Content-Type header in the http request so i was getting this error (unsupported media type) which was kind of misleading me as i was consistently changing the http body but the problem was that i did not know that i should include the Content-Type header by this little change hopefully no one gets stuck on the same problem that i got stuck on |
|
@aldas as you said it was not okay to return an error with 500 code as it was clients problem to set the content header so i fixed the problem and i added a test for this error |
| @@ -338,6 +338,7 @@ var ( | |||
| ErrCookieNotFound = errors.New("cookie not found") | |||
| ErrInvalidCertOrKeyType = errors.New("invalid cert or key type, must be string or []byte") | |||
| ErrInvalidListenerNetwork = errors.New("invalid listener network") | |||
| ErrEmptyContentType = ErrUnsupportedMediaType.WithInternal(errors.New("missing content type header")) | |||
There was a problem hiding this comment.
please do not add new public error - I do not think this case is something that you would actively check. By making it public instead of just returning ErrUnsupportedMediaType.WithInternal(errors.New("missing content type header")) we are making contract library users that there is logic somewhere that returns that error and we can not change it. This is not probably this kind of situation where we should make such strong commitment.
There was a problem hiding this comment.
Hi @aldas , Does this PR need some cleaning before becoming eligible for merge? I would like to take this, if possible.
Updated the code to handle the scenario when the content type in the request header is an empty string. Added a custom error to handle this scenario. No changes were made to other parts of the code.