bind to single string for map[string]interface{}{}

labstack · Jul 19, 2024 · 62fe8cd · 62fe8cd
1 parent 9622474
commit 62fe8cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/bind.go b/bind.go
@@ -160,11 +160,9 @@ func (b *DefaultBinder) bindData(destination interface{}, data map[string][]stri
 			if isElemString {
 				val.SetMapIndex(reflect.ValueOf(k), reflect.ValueOf(v[0]))
 			} else if isElemInterface {
-				if len(v) == 1 {
-					val.SetMapIndex(reflect.ValueOf(k), reflect.ValueOf(v[0]))
-				} else {
-					val.SetMapIndex(reflect.ValueOf(k), reflect.ValueOf(v))
-				}
+				// To maintain backward compatibility, we always bind to the first string value
+				// and not the slice of strings when dealing with map[string]interface{}{}
+				val.SetMapIndex(reflect.ValueOf(k), reflect.ValueOf(v[0]))
 			} else {
 				val.SetMapIndex(reflect.ValueOf(k), reflect.ValueOf(v))
 			}

diff --git a/bind_test.go b/bind_test.go
@@ -497,7 +497,7 @@ func TestDefaultBinder_bindDataToMap(t *testing.T) {
 		assert.NoError(t, new(DefaultBinder).bindData(&dest, exampleData, "param"))
 		assert.Equal(t,
 			map[string]interface{}{
-				"multiple": []string{"1", "2"},
+				"multiple": "1",
 				"single":   "3",
 			},
 			dest,
@@ -509,7 +509,7 @@ func TestDefaultBinder_bindDataToMap(t *testing.T) {
 		assert.NoError(t, new(DefaultBinder).bindData(&dest, exampleData, "param"))
 		assert.Equal(t,
 			map[string]interface{}{
-				"multiple": []string{"1", "2"},
+				"multiple": "1",
 				"single":   "3",
 			},
 			dest,