[proposal] adding configurable status resolver on prometheus middleware #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 64.08% 63.77% -0.32%
==========================================
Files 9 9
Lines 944 969 +25
==========================================
+ Hits 605 618 +13
- Misses 300 308 +8
- Partials 39 43 +4 ☔ View full report in Codecov by Sentry. |
aldas
reviewed
Feb 4, 2025
aldas
reviewed
Feb 4, 2025
aldas
requested changes
Feb 4, 2025
Lee-Minjea
force-pushed
the
feat/status_resolver
branch
2 times, most recently
from
3530fe5 to
ba778c8
Compare
Lee-Minjea
force-pushed
the
feat/status_resolver
branch
from
ba778c8 to
1e69e54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related : #125
Add an
errorToStatusCodeResolveroption to theMiddlewareConfigthat resolves error to status code.Default behavior should remain as it is, referencing
echo.HTTPError.