refactor: clap upgrade to v4
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CHOUMnote
changed the title
clap upgrade(v3 to v4) and refactoring
Closed
jopemachine
reviewed
Aug 12, 2024
jopemachine
reviewed
Aug 12, 2024
jopemachine
reviewed
Aug 12, 2024
jopemachine
reviewed
Aug 12, 2024
jopemachine
reviewed
Aug 12, 2024
jopemachine
requested changes
Aug 13, 2024
|
@jopemachine I have applied the code. Please review it. |
jopemachine
reviewed
Aug 13, 2024
jopemachine
changed the title
clap upgrade(v3 to v4) and refactoringclap upgrade to v4
|
i have a question. do you recommend not to write comments as much as possible? |
No, I'm not saying don't comment; rather, the code should be self-explanatory. Comments should explain things that cannot be explained by the code itself, not repeat what the code already expresses. I think this code is already sufficiently self-explanatory, so additional comments are not necessary. |
|
@CHOUMnote Thank you for your contribution! ❤️ |
jopemachine
added
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using
version 3 of Clap, so we upgraded toversion 4. However, this caused compile errors due to the version upgrade, leading us to remove a lot of legacy code and refactor the project.Note) I tested the
debugoption as thoroughly as possible, but I was unable to test thedumpoption because I didn't know how to use it.