Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-250): show session idle checker in session detail panel #3061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Jan 21, 2025

resolves #3062 (FR-250)

The issues below will be addressed as separate issues.

  • Utilization checks should add heterogeneity support, currently only checks for cuda and ipu devices.
  • Utilization checks should return the device key as the key of the device metadata.
  • The session end time calculated by the idle checker is �returned as remaining (sec) and calculated on the client side, which may cause an error from the actual calculated value.

Changes:

  • Provide idle check information in the session details panel.
  • Fixed SessionDetailContent to use fetchKey of SessionDetailDrawer as controllableState for refetch session data via session status.
  • Sends an interval network request to update the information in the idle checker.
  • Displays an alert at the top of the drawer when the session end time, as calculated by the Idle checker, is imminent.

How to test:

  • Enable idle checker on the resource policy page of the control panel.
  • You can set the session end time through the session lifetime and idle timeout settings in the keypair resource policy.
  • (Control Panel Only) You can set the session end time throught the Time window setting in the idle checker setting modal.
  • Shows the idle check column only for "RUNNING" status sessions. Verify that the column is not visible for sessions in other statuses.
  • No timer is provided for options that are not enabled in idle checker (idle checker has Network Idle Timeout, Utilization checker, and Session lifetime fields).

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:S 10~30 LoC label Jan 21, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 changed the title feat: show session idle checker in session detail panel feat(FR-250): show session idle checker in session detail panel Jan 21, 2025
@ironAiken2 ironAiken2 force-pushed the feat/session-idle-checker-in-detail-panel branch from 627caeb to 7fcbde4 Compare January 22, 2025 05:45
@github-actions github-actions bot added area:lib Library and SDK related issue. size:L 100~500 LoC and removed size:S 10~30 LoC labels Jan 22, 2025
@ironAiken2 ironAiken2 force-pushed the feat/session-idle-checker-in-detail-panel branch from 7fcbde4 to 6914b8c Compare January 22, 2025 08:28
Copy link

github-actions bot commented Jan 22, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.85% (-0.05% 🔻)
398/8200
🔴 Branches
4.19% (-0.06% 🔻)
239/5709
🔴 Functions
2.93% (-0.02% 🔻)
78/2659
🔴 Lines
4.77% (-0.05% 🔻)
383/8022
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / SessionIdleChecks.tsx
0% 0% 0% 0%
🔴
... / IdleCheckDescriptionModal.tsx
0% 100% 0% 0%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 helper/index.tsx
43.14% (-9.87% 🔻)
37.62% (-7.08% 🔻)
37.78% (-3.69% 🔻)
43.17% (-11.31% 🔻)

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 6a5b89a

@ironAiken2 ironAiken2 force-pushed the feat/session-idle-checker-in-detail-panel branch from 6914b8c to e705eba Compare January 23, 2025 05:14
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC and removed size:L 100~500 LoC labels Jan 23, 2025
@ironAiken2 ironAiken2 force-pushed the feat/session-idle-checker-in-detail-panel branch from e705eba to bea2be7 Compare January 23, 2025 05:15
@ironAiken2 ironAiken2 marked this pull request as ready for review January 23, 2025 05:32
@ironAiken2 ironAiken2 marked this pull request as draft January 24, 2025 06:51
@ironAiken2 ironAiken2 force-pushed the feat/session-idle-checker-in-detail-panel branch from bea2be7 to 6a5b89a Compare January 24, 2025 07:05
@ironAiken2 ironAiken2 marked this pull request as ready for review January 24, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add session idle checker into Session Detail Panel
1 participant