-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(FR-29): upgrade to React 19 stable #2926
base: main
Are you sure you want to change the base?
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.9% | 398/8116 |
🔴 | Branches | 4.24% (-0% 🔻) |
239/5637 |
🔴 | Functions | 2.95% | 78/2643 |
🔴 | Lines | 4.82% | 383/7941 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 0036964
f83d2ab
to
d49d94b
Compare
d49d94b
to
1e848d1
Compare
1e848d1
to
4826cc3
Compare
4826cc3
to
82d05a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import '@ant-design/v5-patch-for-react-19'; | ||
import '@ant-design/v5-patch-for-react-19'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import '@ant-design/v5-patch-for-react-19'; | |
import '@ant-design/v5-patch-for-react-19'; | |
import '@ant-design/v5-patch-for-react-19'; |
backend.ai-webui/react/src/components/ResourceAllocationFormItems.tsx Lines 1032 to 1038 in a48214d
Please check this as well. |
@ironAiken2 Did you restart react dev server, after running |
1fde7bc
to
0036964
Compare
Resolves #2925
Upgrade the project to React 19, update Ant Design and related packages, and fix type errors throughout the codebase. Follow the Ant Design guide for compatibility with React 19.
https://ant.design/docs/react/v5-for-19