Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(FR-29): upgrade to React 19 stable #2926

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Dec 9, 2024

Resolves #2925

Upgrade the project to React 19, update Ant Design and related packages, and fix type errors throughout the codebase. Follow the Ant Design guide for compatibility with React 19.

https://ant.design/docs/react/v5-for-19

Copy link

graphite-app bot commented Dec 9, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:XL 500~ LoC label Dec 9, 2024
Copy link
Member Author

yomybaby commented Dec 9, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby marked this pull request as ready for review December 9, 2024 03:29
Copy link

github-actions bot commented Dec 9, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.9% 398/8116
🔴 Branches
4.24% (-0% 🔻)
239/5637
🔴 Functions 2.95% 78/2643
🔴 Lines 4.82% 383/7941

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 0036964

@yomybaby yomybaby marked this pull request as draft December 9, 2024 03:30
@yomybaby yomybaby force-pushed the chore/react-19-stable branch from f83d2ab to d49d94b Compare December 20, 2024 03:46
@yomybaby yomybaby force-pushed the chore/react-19-stable branch from d49d94b to 1e848d1 Compare December 31, 2024 04:13
@yomybaby yomybaby changed the title bump: React 19 stable [FR-29] misc: upgrade to React 19 stable Dec 31, 2024
@yomybaby yomybaby changed the title [FR-29] misc: upgrade to React 19 stable misc(FR-29): upgrade to React 19 stable Jan 14, 2025
@yomybaby yomybaby force-pushed the chore/react-19-stable branch from 1e848d1 to 4826cc3 Compare January 16, 2025 01:28
@yomybaby yomybaby force-pushed the chore/react-19-stable branch from 4826cc3 to 82d05a9 Compare January 23, 2025 06:39
@yomybaby yomybaby marked this pull request as ready for review January 23, 2025 06:40
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

I've found an error, please check.

Comment on lines +14 to +15
import '@ant-design/v5-patch-for-react-19';
import '@ant-design/v5-patch-for-react-19';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import '@ant-design/v5-patch-for-react-19';
import '@ant-design/v5-patch-for-react-19';
import '@ant-design/v5-patch-for-react-19';

Copy link
Contributor

isMinOversMaxValue(
resourceLimits.accelerators[
currentAcceleratorType
]?.min,
resourceLimits.accelerators[
currentAcceleratorType
]?.max,

Please check this as well.

Copy link
Member Author

@ironAiken2 Did you restart react dev server, after running pnpm i. Cloud you please check again? In my dev environment, there is no error.

@yomybaby yomybaby requested a review from ironAiken2 January 24, 2025 10:53
@yomybaby yomybaby force-pushed the chore/react-19-stable branch from 1fde7bc to 0036964 Compare January 24, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade React to version 19 and test Suspense-related changes
2 participants