Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Graph from NetworkX Graph object #9

Closed
buddha314 opened this issue May 9, 2023 · 3 comments · Fixed by #14
Closed

Read Graph from NetworkX Graph object #9

buddha314 opened this issue May 9, 2023 · 3 comments · Fixed by #14
Assignees
Labels
enhancement New feature or request

Comments

@buddha314
Copy link

Feature Request.

While using PyReason as a Python SDK, it would be useful to construct a NetworkX graph as an object programmatically, then pass that into the py engine.

Allow both pr.load_graph(path_to_graph) and pr.load_graph(G) where G = nx.Graph() to avoid having to lay the XML to disk.

@dyumanaditya
Copy link
Contributor

Thanks for this @buddha314. I agree this is important and user friendly, we'll open a PR soon.

@dyumanaditya dyumanaditya added the enhancement New feature or request label May 11, 2023
@dyumanaditya dyumanaditya self-assigned this May 11, 2023
@dyumanaditya dyumanaditya linked a pull request Jun 11, 2023 that will close this issue
22 tasks
@dyumanaditya dyumanaditya mentioned this issue Sep 28, 2023
22 tasks
@buddha314
Copy link
Author

buddha314 commented Nov 28, 2023

Excellent! is there a test or documentation where I can see the usage pattern?

AH! I see it here: https://github.com/lab-v2/pyreason/blob/main/docs/hello-world.py#L6-L23

@dyumanaditya
Copy link
Contributor

dyumanaditya commented Nov 30, 2023

@buddha314 sorry for the late reply, yes that's the correct file to look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants