Added timeout support #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Git class constructor now allows to define a non-standard (60 seconds) timeout for the processes it launches, since many times it is normal that such executions take much more time, specially when cloning or pushing to a new repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Git class constructor now allows to define a non-standard (60 seconds) timeout for the processes it launches, since many times it is normal that such executions take much more time, specially when cloning or pushing to a new repository.
I'm handling big repositories that take a long time to clone and I wasn't being able to clone them (and other operations) through the library, because by default all processes of the Symfony Process Component have a timeout of 60 seconds. I've added an optional parameter on the constructor to change the global timeout to be used in each process launched to make possible to set an higher value.