Use None=0 #144
Draft
Use None=0 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows some code simplifications at the expense of added complexity elsewhere. Overall it seems to be a size reduction. -13 bytes
kz04px
commented
Jan 26, 2023
gcp
reviewed
Jan 26, 2023
| } | ||
| return str; | ||
| } | ||
|
|
||
| [[nodiscard]] int piece_on(const Position &pos, const int sq) { | ||
| const u64 bb = 1ULL << sq; | ||
| for (int i = 0; i < 6; ++i) { | ||
| for (int i = 1; i < 7; ++i) { |
There was a problem hiding this comment.
Can't this run from 0 to 7? (maybe with a compiled out assert for the fallthrough)
| @@ -391,7 +392,7 @@ const int pawn_attacked[] = {S(-64, -14), S(-155, -142)}; | |||
|
|
|||
| // For each piece type | |||
| for (int p = 0; p < 6; ++p) { | |||
There was a problem hiding this comment.
Why isn't this loop simply going from 1 to 7, avoiding all the p + 1? I'd compute that once into a var for the eval array indexing, if only the avoid the eyebleed this is now.
| @@ -487,18 +488,18 @@ const int pawn_attacked[] = {S(-64, -14), S(-155, -142)}; | |||
| u64 hash = pos.flipped; | |||
|
|
|||
| // Pieces | |||
| for (int p = Pawn; p < None; p++) { | |||
| for (int p = 1; p < 7; p++) { | |||
| u64 copy = pos.pieces[p] & pos.colour[0]; | ||
| while (copy) { | ||
| const int sq = lsb(copy); | ||
| copy &= copy - 1; | ||
| hash ^= keys[p * 64 + sq]; | ||
| hash ^= keys[(p - 1) * 64 + sq]; |
There was a problem hiding this comment.
You can cheat and make keys bigger to avoid the -1.
| @@ -424,7 +425,7 @@ const int pawn_attacked[] = {S(-64, -14), S(-155, -142)}; | |||
| score += pawn_attacked[c]; | |||
| } | |||
|
|
|||
| if (p == Pawn) { | |||
| if (p + 1 == Pawn) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code complexity for this is a bit mixed. Indexing based on piece type is now both awkward and inconsistent, but gains are made elsewhere. Would recommend we discuss if this is worthwhile and verify that it's correct. Happy to leave it until size reductions get desperate.