fix: make Home and Config pages scrollable (#40)

kyujin-cho · Feb 12, 2023 · 75b0bbb · 75b0bbb
1 parent 42595df
commit 75b0bbb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/src/main/java/dev/bluehouse/enablevolte/pages/Config.kt b/app/src/main/java/dev/bluehouse/enablevolte/pages/Config.kt
@@ -3,6 +3,8 @@ package dev.bluehouse.enablevolte.pages
 import android.telephony.CarrierConfigManager
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.rememberScrollState
+import androidx.compose.foundation.verticalScroll
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
@@ -27,6 +29,7 @@ import java.lang.IllegalStateException
 fun Config(navController: NavController, subId: Int) {
     val moder = SubscriptionModer(subId)
     val carrierModer = CarrierModer(LocalContext.current)
+    val scrollState = rememberScrollState()
 
     var configurable by rememberSaveable { mutableStateOf(false) }
     var voLTEEnabled by rememberSaveable { mutableStateOf(false) }
@@ -66,7 +69,7 @@ fun Config(navController: NavController, subId: Int) {
         }
     }
 
-    Column(modifier = Modifier.padding(Dp(16f))) {
+    Column(modifier = Modifier.padding(Dp(16f)).verticalScroll(scrollState)) {
         HeaderText(text = "Toggles")
         BooleanPropertyView(label = "Enable VoLTE", toggled = voLTEEnabled) {
             voLTEEnabled = if (voLTEEnabled) {

diff --git a/app/src/main/java/dev/bluehouse/enablevolte/pages/Home.kt b/app/src/main/java/dev/bluehouse/enablevolte/pages/Home.kt
@@ -7,6 +7,8 @@ import android.telephony.SubscriptionInfo
 import android.util.Log
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.rememberScrollState
+import androidx.compose.foundation.verticalScroll
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
@@ -38,6 +40,7 @@ const val TAG = "HomeActivity:Home"
 fun Home(navController: NavController) {
     val carrierModer = CarrierModer(LocalContext.current)
     val context = LocalContext.current
+    val scrollState = rememberScrollState()
 
     var shizukuEnabled by rememberSaveable { mutableStateOf(false) }
     var shizukuGranted by rememberSaveable { mutableStateOf(false) }
@@ -84,7 +87,7 @@ fun Home(navController: NavController) {
         }
     }
 
-    Column(modifier = Modifier.padding(Dp(16f))) {
+    Column(modifier = Modifier.padding(Dp(16f)).verticalScroll(scrollState)) {
         HeaderText(text = "Version")
         if (newerVersion.isNotEmpty()) {
             ClickablePropertyView(label = BuildConfig.VERSION_NAME, value = "Newer version $newerVersion available!") {