Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CommonCrypto to fix builds in Xcode 10 beta #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jondwillis
Copy link

See: #102

@kylef
Copy link
Owner

kylef commented Jun 12, 2018

@jondwillis Can you rework this PR so it works on the current version of Xcode too?

@jonblatho
Copy link
Contributor

I have a fix in #112 for this issue that works across both Swift 4.1.x and Swift 4.2. Earlier versions of Swift aren’t supported because #if canImport(ModuleName) was added in Swift 4.1.

I tried some other ways to get it working on earlier Swift versions and could not get them working reliably, but a better way may exist and I frankly didn’t invest too much time into it. In any case, feel free to borrow the fix if needed.

@Coeur
Copy link

Coeur commented Mar 12, 2019

@kylef According to an Apple news from September 2018, this month of March 2019 will see Xcode 10 being mandatory for publishing iOS apps. And Xcode 10 supports Swift 4.x and #if canImport(), so there is really no need to keep support for older versions of Xcode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants