-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test run locally #246
Conversation
That's very interesting, maybe something's wrong with my configuration. I'll take a look later, thanks for the pointer! |
I checked out your branch and it also doesn't hang anymore, although now it is failing a bunch of test cases, which is less than ideal (and also strange, given that the core plugin doesn't utilize plenary at all). My tests work if I run them file-by-file, and they used to work on an older version of Neovim; I really don't know what happened to it. I do appreciate your work; hopefully I can understand your commit better at some point and isolate what the issue is. |
I did fix the issue. The answer is always simple. I forgot to add:
|
@@ -35,10 +35,6 @@ jobs: | |||
neovim: true | |||
version: nightly | |||
|
|||
- name: Install plenary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Run tests | ||
run: nvim --headless --noplugin -c 'packadd plenary.nvim' -c "PlenaryBustedDirectory tests/ { minimal_init = 'tests/minimal_init.lua' }" | ||
run: make test_lua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reuse logic from Makefile
so it's not duplicated.
PS. Maybe you think I should remove Makefile
I'm not entirely sure what happened, but I updated plenary and it seems to be working for me again(?) Thanks for taking the time to submit the PR nonetheless (and sorry for the radio silence)! |
Hello! Thank you for this plugin! It's awesome!
I saw your comment here. So, I decided to give it a try.
I managed to run tests locally. They didn't hang.
But some of them were failing:
PS. I'm sure that this is not the solution, but hope this may help you find the solution.