Phase 14 - Refactoring: Forgot to create the Config Actor#190
Open
lorenzoberts wants to merge 4 commits into
Open
Phase 14 - Refactoring: Forgot to create the Config Actor#190lorenzoberts wants to merge 4 commits into
lorenzoberts wants to merge 4 commits into
Conversation
This commit moves configuration bootstrap, directory setup, and update validation into reusable helpers while keeping the existing synchronous service API intact. The extraction prepares configuration state and validation for actor ownership without changing runtime behavior. This commit is part of the architecture's refactoring phase 14. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit introduces the configuration actor boundary with ConfigMessage, ConfigHandle, and ConfigActor for snapshot reads, validated updates, persistence, and shutdown. The actor is added in isolation from production wiring so its lifecycle and request protocol can be tested independently. This commit is part of the architecture's refactoring phase 14. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit wires ConfigActor into startup and passes ConfigHandle through AppServices so edit-config saves use the typed actor protocol. Bootstrap still produces the initial snapshot for logging, CLI handling, Lore setup, and App state, preserving the existing startup path while moving mutations behind the actor boundary. This commit is part of the architecture's refactoring phase 14. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit removes the legacy ConfigService wrapper now that runtime configuration updates go exclusively through ConfigHandle. Configuration tests are updated to exercise the bootstrap helpers and actor-backed apply path directly, leaving the config module aligned with the hybrid actor model. This commit completes the architecture's refactoring phase 14. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Promote ConfigService from a synchronous service object to a proper actor with its own state, lifecycle, and typed message protocol — consistent with LoreApiActor, RenderActor, and the rest of the actor fleet.
What this PR does
Extracts bootstrap, directory setup, and update validation into reusable helpers, then introduces ConfigMessage, ConfigHandle, and ConfigActor for snapshot reads, validated updates, persistence, and shutdown. main.rs spawns ConfigActor at startup; AppServices holds ConfigHandle and edit-config saves go through the typed actor protocol instead of calling ConfigService directly.
Bootstrap still produces the initial ConfigSnapshot for logging, CLI handling, Lore setup, and App state. The legacy synchronous ConfigService API is removed once all runtime mutations go exclusively through ConfigHandle. Runtime behavior is unchanged.