Skip to content

Move dependecy check out of run_app #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ivinjabraham
Copy link
Contributor

I think it is cleaner for run_app to be focused on just running the app. Checks for dependencies can be done outside of this step.

The first step in `run_app` is to check if necessary external
dependencies are installed. This does not need to be a method of the
`App` struct nor does it need to part of `run_app`. Move dependecy check
out of `run_app`.

In the future, this check can be made by injecting any necessary
configuration information instead of it being a method on the `App` struct.

Signed-off-by: Ivin Joel Abraham <[email protected]>
@ivinjabraham ivinjabraham changed the base branch from master to unstable June 29, 2025 04:43
@davidbtadokoro
Copy link
Collaborator

Hey @ivinjabraham, thank you so much for the PR. It makes sense to me this move, as, if dependencies are not present, we shouldn't even start run_app(). Cleanly applied, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants