fix: patch-hub crashes when loading patches after b4 fails #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeking to fix kworkflow#69, this commit introduces a check to the function init_details_actions. We hoped to stop the crash described in kworkflow#69 by throwing an Err and catching it in the handle_latest_patchsets fucntion before showing a popup to the user. For some still unkown reason, the TUI freezes and 'melts' after the popup is shown. Co-developed-by: Bruno Stephan <[email protected]> Signed-off-by: Bruno Stephan <[email protected]> Co-developed-by: Andre de Lima <[email protected]> Signed-off-by: Andre de Lima <[email protected]> Signed-off-by: Arthur Pilone <[email protected]>
|
@davidbtadokoro and @lorenzoberts we'd really appreciate it if you could check out this bug our partial "fix" introduces. It seems to have something to do with the rendering or with the thread management. Try to reproduce the original bug from #69 with the patch Do you guys have any info or what exactly we should look after in order to fix this? |
This commit fixes the previous one. The terminal was unresponsive because the macro received an Err. We created a new enum to test whether the init_details_action function found a patch in the expected path. This enum is used to test whether the file exists in the handle_latest_patchsets function still using an Ok(). Fixes: kworkflow#69 Co-developed-by: Bruno Stephan <[email protected]> Signed-off-by: Bruno Stephan <[email protected]> Co-developed-by: Andre de Lima <[email protected]> Signed-off-by: Andre de Lima <[email protected]> Signed-off-by: Arthur Pilone <[email protected]>
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeking to fix #69, this first commit introduces a check to the function init_details_actions. We hoped to stop the crash described in #69 by throwing an Err and catching it in the handle_latest_patchsets fucntion before showing a popup to the user. For some still unkown reason, the TUI freezes and 'melts' after the popup is shown.
Co-developed-by: Bruno Stephan [email protected]
Co-developed-by: Andre de Lima [email protected]