Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing generics to Router stages (in options) #241

Merged
merged 7 commits into from
Apr 14, 2024
Merged

Add missing generics to Router stages (in options) #241

merged 7 commits into from
Apr 14, 2024

Conversation

kwhitley
Copy link
Owner

Description

Router generics did not extend to before and finally stages in router options.

Type of Change (select one and follow subtasks)

  • Documentation (README.md)
  • Maintenance or repo-level work (e.g. linting, build, tests, refactoring, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
    • I have included test coverage
  • Breaking change (fix or feature that would cause existing functionality/userland code to not work as expected)
    • Explain why a breaking change is necessary:
  • This change requires (or is) a documentation update
    • I have added necessary local documentation (if appropriate)
    • I have added necessary itty.dev documentation (if appropriate)

@kwhitley kwhitley added the BUG Something isn't working label Apr 14, 2024
@kwhitley kwhitley changed the title checking in stuff Add missing generics to Router stages (in options) Apr 14, 2024
@kwhitley kwhitley merged commit ca742e4 into v5.x Apr 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BUG Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kwhitley