Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: v5.1 - adds withParams option to AutoRouter #238

Closed
wants to merge 5 commits into from

Conversation

kwhitley
Copy link
Owner

@kwhitley kwhitley commented Apr 9, 2024

Changes

  • adds withParams as an option (defaults to withParams to AutoRouter. Set to a no-op to bypass.
  • websocket (undocumented) now uses a standard Response, rather than createResponse (saves ~100 bytes)
  • withParams internal has been restructured to save ~10 bytes

Type of Change (select one and follow subtasks)

  • Documentation (README.md)
  • Maintenance or repo-level work (e.g. linting, build, tests, refactoring, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
    • I have included test coverage
  • Breaking change (fix or feature that would cause existing functionality/userland code to not work as expected)
    • Explain why a breaking change is necessary:
  • This change requires (or is) a documentation update
    • I have added necessary local documentation (if appropriate)
    • I have added necessary itty.dev documentation (if appropriate)

@kwhitley
Copy link
Owner Author

As always, after a few days I debate the need for such a think... and I think if you specifically needed around withParams (it's rare), you could just use Router instead.

@kwhitley
Copy link
Owner Author

closing this... ultimately, perhaps not worth the calories.

@kwhitley kwhitley closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant