Skip to content

Remove enabled check from semi mask #5221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2025

Conversation

andyfengHKU
Copy link
Contributor

Description

The convention is to use nullptr to represent a mask is enabled or not. So this PR removes the enable interface from NodeOffsetMask

Fixes # (issue)

Contributor agreement

@andyfengHKU andyfengHKU marked this pull request as ready for review April 11, 2025 05:29
Copy link

Benchmark Result

Master commit hash: fe12d4ff35316fbbdc2b24df74573340476ad3db
Branch commit hash: bc003d53b5fd0ad28545eae4f40124ad8712b153

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 730.82 724.03 6.80 (0.94%)
aggregation q28 6563.50 6472.64 90.87 (1.40%)
filter q14 132.67 124.77 7.91 (6.34%)
filter q15 135.56 126.44 9.12 (7.21%)
filter q16 349.47 346.47 3.01 (0.87%)
filter q17 453.09 447.39 5.70 (1.27%)
filter q18 1866.05 1915.62 -49.57 (-2.59%)
filter zonemap-node 88.73 88.25 0.48 (0.54%)
filter zonemap-node-lhs-cast 89.51 88.81 0.69 (0.78%)
filter zonemap-node-null 88.98 89.74 -0.75 (-0.84%)
filter zonemap-rel 5509.23 5395.33 113.90 (2.11%)
fixed_size_expr_evaluator q07 692.52 678.12 14.40 (2.12%)
fixed_size_expr_evaluator q08 972.58 961.54 11.04 (1.15%)
fixed_size_expr_evaluator q09 970.86 959.47 11.38 (1.19%)
fixed_size_expr_evaluator q10 269.06 254.33 14.73 (5.79%)
fixed_size_expr_evaluator q11 270.59 255.61 14.98 (5.86%)
fixed_size_expr_evaluator q12 248.26 236.07 12.19 (5.16%)
fixed_size_expr_evaluator q13 1577.42 1560.93 16.49 (1.06%)
fixed_size_seq_scan q23 121.72 112.25 9.47 (8.44%)
join q29 754.64 738.57 16.07 (2.18%)
join q30 1540.92 1550.70 -9.78 (-0.63%)
join q31 5.82 6.04 -0.21 (-3.49%)
join SelectiveTwoHopJoin 47.49 54.63 -7.14 (-13.08%)
ldbc_snb_ic q35 9.52 10.84 -1.32 (-12.19%)
ldbc_snb_ic q36 102.59 93.17 9.42 (10.11%)
ldbc_snb_is q32 6.35 5.14 1.22 (23.69%)
ldbc_snb_is q33 12.99 12.42 0.57 (4.59%)
ldbc_snb_is q34 1.07 1.41 -0.35 (-24.52%)
multi-rel multi-rel-large-scan 1991.15 2031.35 -40.19 (-1.98%)
multi-rel multi-rel-lookup 12.50 12.19 0.31 (2.58%)
multi-rel multi-rel-small-scan 226.19 206.40 19.79 (9.59%)
order_by q25 139.81 131.46 8.36 (6.36%)
order_by q26 452.63 447.91 4.72 (1.05%)
order_by q27 1415.75 1389.76 25.99 (1.87%)
recursive_join recursive-join-bidirection 289.84 284.08 5.76 (2.03%)
recursive_join recursive-join-dense 7159.51 7151.56 7.95 (0.11%)
recursive_join recursive-join-path 23006.30 23295.72 -289.42 (-1.24%)
recursive_join recursive-join-sparse 628.68 634.91 -6.23 (-0.98%)
recursive_join recursive-join-trail 7081.02 7097.63 -16.61 (-0.23%)
scan_after_filter q01 176.75 168.21 8.53 (5.07%)
scan_after_filter q02 162.05 154.95 7.09 (4.58%)
shortest_path_ldbc100 q37 85.49 85.31 0.17 (0.20%)
shortest_path_ldbc100 q38 320.54 334.76 -14.22 (-4.25%)
shortest_path_ldbc100 q39 60.98 65.48 -4.51 (-6.88%)
shortest_path_ldbc100 q40 417.68 283.63 134.05 (47.26%)
var_size_expr_evaluator q03 2150.00 2117.62 32.38 (1.53%)
var_size_expr_evaluator q04 2185.99 2212.55 -26.55 (-1.20%)
var_size_expr_evaluator q05 2607.52 2684.49 -76.97 (-2.87%)
var_size_expr_evaluator q06 1347.78 1364.77 -16.99 (-1.24%)
var_size_seq_scan q19 1439.19 1437.37 1.82 (0.13%)
var_size_seq_scan q20 2506.44 2370.08 136.37 (5.75%)
var_size_seq_scan q21 2244.71 2250.91 -6.19 (-0.28%)
var_size_seq_scan q22 126.79 126.30 0.48 (0.38%)

Copy link

Benchmark Result

Master commit hash: fe12d4ff35316fbbdc2b24df74573340476ad3db
Branch commit hash: 69952408708202de93a099c8dc98ace56cb366c8

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 724.60 724.03 0.57 (0.08%)
aggregation q28 6584.89 6472.64 112.25 (1.73%)
copy node-Comment 77809.06 N/A N/A
copy node-Forum 5356.79 N/A N/A
copy node-Organisation 1183.48 N/A N/A
copy node-Person 1990.80 N/A N/A
copy node-Place 1142.81 N/A N/A
copy node-Post 31865.99 N/A N/A
copy node-Tag 1275.20 N/A N/A
copy node-Tagclass 1135.51 N/A N/A
copy rel-comment-hasCreator 54511.89 N/A N/A
copy rel-comment-hasTag 76681.29 N/A N/A
copy rel-comment-isLocatedIn 62917.21 N/A N/A
copy rel-containerOf 14826.89 N/A N/A
copy rel-forum-hasTag 3592.97 N/A N/A
copy rel-hasInterest 2648.86 N/A N/A
copy rel-hasMember 53046.82 N/A N/A
copy rel-hasModerator 1253.96 N/A N/A
copy rel-hasType 251.98 N/A N/A
copy rel-isPartOf 214.06 N/A N/A
copy rel-isSubclassOf 212.76 N/A N/A
copy rel-knows 6330.93 N/A N/A
copy rel-likes-comment 94193.19 N/A N/A
copy rel-likes-post 34319.08 N/A N/A
copy rel-organisation-isLocatedIn 233.41 N/A N/A
copy rel-person-isLocatedIn 459.32 N/A N/A
copy rel-post-hasCreator 15228.34 N/A N/A
copy rel-post-hasTag 20300.63 N/A N/A
copy rel-post-isLocatedIn 16194.09 N/A N/A
copy rel-replyOf-comment 51538.15 N/A N/A
copy rel-replyOf-post 40635.53 N/A N/A
copy rel-studyAt 494.97 N/A N/A
copy rel-workAt 699.42 N/A N/A
filter q14 136.69 124.77 11.92 (9.56%)
filter q15 139.63 126.44 13.19 (10.43%)
filter q16 343.32 346.47 -3.14 (-0.91%)
filter q17 447.20 447.39 -0.18 (-0.04%)
filter q18 1929.66 1915.62 14.04 (0.73%)
filter zonemap-node 88.80 88.25 0.55 (0.63%)
filter zonemap-node-lhs-cast 88.88 88.81 0.06 (0.07%)
filter zonemap-node-null 89.34 89.74 -0.40 (-0.45%)
filter zonemap-rel 5725.99 5395.33 330.66 (6.13%)
fixed_size_expr_evaluator q07 680.36 678.12 2.24 (0.33%)
fixed_size_expr_evaluator q08 964.48 961.54 2.95 (0.31%)
fixed_size_expr_evaluator q09 964.58 959.47 5.10 (0.53%)
fixed_size_expr_evaluator q10 254.83 254.33 0.50 (0.20%)
fixed_size_expr_evaluator q11 254.96 255.61 -0.65 (-0.25%)
fixed_size_expr_evaluator q12 233.40 236.07 -2.67 (-1.13%)
fixed_size_expr_evaluator q13 1562.42 1560.93 1.49 (0.10%)
fixed_size_seq_scan q23 114.56 112.25 2.31 (2.06%)
join q29 699.99 738.57 -38.58 (-5.22%)
join q30 1551.47 1550.70 0.78 (0.05%)
join q31 7.08 6.04 1.04 (17.26%)
join SelectiveTwoHopJoin 62.19 54.63 7.56 (13.83%)
ldbc_snb_ic q35 10.19 10.84 -0.65 (-5.97%)
ldbc_snb_ic q36 107.55 93.17 14.38 (15.43%)
ldbc_snb_is q32 3.55 5.14 -1.58 (-30.82%)
ldbc_snb_is q33 16.02 12.42 3.60 (28.96%)
ldbc_snb_is q34 1.38 1.41 -0.03 (-2.27%)
multi-rel multi-rel-large-scan 1697.39 2031.35 -333.95 (-16.44%)
multi-rel multi-rel-lookup 10.20 12.19 -1.99 (-16.35%)
multi-rel multi-rel-small-scan 209.30 206.40 2.90 (1.40%)
order_by q25 132.50 131.46 1.04 (0.79%)
order_by q26 444.01 447.91 -3.90 (-0.87%)
order_by q27 1405.56 1389.76 15.80 (1.14%)
recursive_join recursive-join-bidirection 312.52 284.08 28.45 (10.01%)
recursive_join recursive-join-dense 7057.93 7151.56 -93.63 (-1.31%)
recursive_join recursive-join-path 23526.71 23295.72 230.98 (0.99%)
recursive_join recursive-join-sparse 631.23 634.91 -3.67 (-0.58%)
recursive_join recursive-join-trail 7047.00 7097.63 -50.63 (-0.71%)
scan_after_filter q01 179.25 168.21 11.04 (6.56%)
scan_after_filter q02 155.47 154.95 0.52 (0.34%)
shortest_path_ldbc100 q37 92.94 85.31 7.63 (8.94%)
shortest_path_ldbc100 q38 274.58 334.76 -60.18 (-17.98%)
shortest_path_ldbc100 q39 57.54 65.48 -7.95 (-12.14%)
shortest_path_ldbc100 q40 409.62 283.63 126.00 (44.42%)
var_size_expr_evaluator q03 2090.47 2117.62 -27.15 (-1.28%)
var_size_expr_evaluator q04 2256.12 2212.55 43.57 (1.97%)
var_size_expr_evaluator q05 2712.03 2684.49 27.54 (1.03%)
var_size_expr_evaluator q06 1361.06 1364.77 -3.71 (-0.27%)
var_size_seq_scan q19 1435.21 1437.37 -2.15 (-0.15%)
var_size_seq_scan q20 2695.71 2370.08 325.63 (13.74%)
var_size_seq_scan q21 2263.78 2250.91 12.87 (0.57%)
var_size_seq_scan q22 126.06 126.30 -0.25 (-0.20%)

@andyfengHKU andyfengHKU merged commit b321100 into master Apr 12, 2025
@andyfengHKU andyfengHKU deleted the remove-enabled-check-from-semi-mask branch April 12, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants