rust: bump min rust version to 1.81, update CI #5185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5185 +/- ##
==========================================
- Coverage 86.97% 86.97% -0.01%
==========================================
Files 1405 1405
Lines 61635 61659 +24
Branches 7544 7550 +6
==========================================
+ Hits 53607 53627 +20
- Misses 7855 7859 +4
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sdht0
commented
Apr 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
benjaminwinger
approved these changes
Apr 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
sdht0
changed the title
sdht0
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
sdht0
commented
Apr 14, 2025
benjaminwinger
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
I'm not sure we should be setting the minimum supported rust-version based on our dependencies (particularly optional ones).
Unfortunately, Cargo doesn't handle this very well, but eventually it will default to selecting versions based on their rust-version (see here), which means that we would be able to do things like indicating that we support a range of arrow versions and it will use the one supported by your current version of the compiler (currently we can also do that, but I think it will pull in the latest version and error saying that it needs a newer rust compiler, so you would have to manually pin the version of arrow that you want to use).
| cxx = "1.0" | ||
| arrow = { version = "55", optional = true, default-features = false, features = ["ffi"] } | ||
| cxx = "=1.0.138" # latest version that builds on clang 15 | ||
| rust_decimal = { version = "1.37", default-features = false } |
There was a problem hiding this comment.
Why bump the rust_decimal version? We haven't changed anything we do with rust_decimal since adding it, so it's unlikely that it's no longer working with 1.35, and this keeps things compatible with another crate if they need to use 1.35/1.36 for some particular reason (E.g. the above cxx pin). We could probably even push the requirement back earlier since the only function we use was introduced in version 1.2.1 (I haven't tested it with that version though).
There was a problem hiding this comment.
I was following the "best practice" of updating frequently so that the ecosystem is not stuck on older version, esp through transitive dependencies.
There was a problem hiding this comment.
This doesn't force 1.35 though; the default is the ^ operator which would mean >=1.35,<2 (see here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.74 since 1.72 was already needed forarrowand 1.74 is the first version to supportlints.clippyinCargo.toml.Moving to 1.81 for latest version of
arrowandhalfwhile we're at it.Shared builds on macOS now work.
Personal preference is to enable all clippy lints and then selectively disable the unwanted ones. Happy to consider disabling at least the
pedanticones by default.Contributor agreement