Add setWindowFlags to QMainWindowWrapper #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciek134
force-pushed
the
feat/setWindowFlags
branch
2 times, most recently
from
b0bd388
to
a48423f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
setWindowFlagstoQMainWindowWrapper, so we can have stuff like dialogs and chromeless windows.I see that I have a newer Qt version (5.15.0 vs 5.9.5) but the MOC version is the same, so it should be alright.
EDIT: well, Qt version may be alright, but it also uses newer C++ features that the msbuild on the CI doesn't support.