Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(xds): remove back compat for old dns filter #6226

Merged
merged 2 commits into from
Mar 8, 2023
Merged

chore(xds): remove back compat for old dns filter #6226

merged 2 commits into from
Mar 8, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Mar 7, 2023

This was introduced to support envoy < 1.20 which we no longer need to support

xref #3499

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
chore(xds): remove back compat for old dns filter
ba1a2ef 
This was introduced to support envoy < 1.20 which we no longer need to
support

xref #3499

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested review from a team, lobkovilya and lukidzi and removed request for a team March 7, 2023 16:11
@lahabana
Copy link
Contributor Author

lahabana commented Mar 7, 2023

/format

@github-actions
fix(ci): format files
b3de25f 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lahabana lahabana merged commit 4ac717b into master Mar 8, 2023
@lahabana lahabana deleted the removeOldDnsFilter branch March 8, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @slonka