feat(kuma-cp): allow skipping certain label propagation on multizone #11918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
changed the title
michaelbeaumont
force-pushed
the
feat/skip-kds-labels
branch
4 times, most recently
from
eade603
to
09fcd8e
Compare
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
feat/skip-kds-labels
branch
from
09fcd8e
to
cff369c
Compare
michaelbeaumont
requested review from
jijiechen
and removed request for
a team
lobkovilya
approved these changes
Oct 30, 2024
Signed-off-by: Mike Beaumont <[email protected]>
jijiechen
reviewed
Nov 11, 2024
| @@ -67,6 +67,7 @@ func setupKubeZone(wg *sync.WaitGroup, clusterName string, extraOptions ...frame | |||
| // 100s and 80s are values that we also use in mesh-perf when we put a lot of pressure on the CP. | |||
| framework.WithEnv("KUMA_RUNTIME_KUBERNETES_LEADER_ELECTION_LEASE_DURATION", "100s"), | |||
| framework.WithEnv("KUMA_RUNTIME_KUBERNETES_LEADER_ELECTION_RENEW_DEADLINE", "80s"), | |||
| framework.WithEnv("KUMA_MULTIZONE_ZONE_KDS_LABELS_SKIP_PREFIXES", "argocd.argoproj.io"), | |||
There was a problem hiding this comment.
It's worth testing multiple prefixes and asserting both of them are skipped.
jijiechen
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users might not want certain labels to be propagated between control planes.
Implementation information
Two config values, one for zone and one for global.
Supporting documentation
Closes #11416