feat: 一括選択のチェックボックスに可視のラベルを追加 #4149
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for smarthr-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
masuP9
force-pushed
the
feat/table-header-input-label
branch
from
52bf4f7
to
28909fe
Compare
masuP9
force-pushed
the
feat/table-header-input-label
branch
2 times, most recently
from
1664c1a
to
7c373bf
Compare
masuP9
force-pushed
the
feat/table-header-input-label
branch
from
7c373bf
to
46ec2c2
Compare
masuP9
force-pushed
the
feat/table-header-input-label
branch
from
46ec2c2
to
776d1fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
<Table>のヘッダーセルにあるチェックボックスには、マシンリーダブルなラベルはあるが可視のラベルがなかったため追加。参考: フォーム: ウェブアクセシビリティ簡易チェックリスト | アクセシビリティ | SmartHR Design System
What I did
テキストラベルを表示するスペースがセル内に無いため、マウスポインターがホバーした際、またはフォーカスした際に、「すべての行を選択」のツールチップを出した。
ヘッダーセルを固定した際に、
<Table>コンポーネントの描画範囲外が描画されなくなるため、ツールチップは右側に出した。（右側の見出しセルが見えなくなるけど。。。）その他
<ThCheckbox>は<th>でレンダリングされ、内包するコンテンツが「すべての行を選択」になるので、チェックボックスがあるカラムの名前が「すべての行を選択」になってしまう。そのことを回避するために
<th>にaria-labelを付与し、内包するコンテンツを無視して「選択」というカラム名に変更した。