show download speed with the correct units #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubilus1
reviewed
Aug 16, 2023
Comment on lines
230
to
+233
| cur_activity['pcnt_done'] = pcnt_done | ||
| cur_activity['MBps'] = MBps | ||
| print(f"\r{pcnt_done:.2f}% {MBps:.2f} MBps", end='') | ||
| cur_activity['status'] = f"Downloading {self.dl_url}\n{pcnt_done:.2f}% {MBps:.2f} MBps" | ||
| print(f"\r{pcnt_done:.2f}% {MBps:.2f} Mbps", end='') | ||
| cur_activity['status'] = f"Downloading {self.dl_url}\n{pcnt_done:.2f}% {MBps:.2f} Mbps" |
There was a problem hiding this comment.
Agree this is confusing. I think the rest of the references should also be updated to reflect this.
Also, I think the lines:
cur_activity['pcnt_done'] = pcnt_done
cur_activity['MBps'] = MBps
Can go away if the corresponding lines (350,351) in config_ui.py are removed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These speeds are in Megabits per second, a capital B signified Megabytes per second. This fixes the discrepancy.