-
Notifications
You must be signed in to change notification settings - Fork 10
Add release tracker issue template #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd appreciate having the lane bump as a separate action item.
Also the stabilization should be done per SIG, probably a check as reminder will help.
e618f51
to
f18527a
Compare
@fossedihelm we can also add an action-item to create a new release directory under api testdata during the code-freeze. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably name the sigs that own the action items. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you @fossedihelm
@dhiller We can, but still not sure how, trying to keep the template lightweight. WDYT about a followup? |
f18527a
to
bc3a481
Compare
Agree, let's capture that thought in a follow up and then we should be good to go. /lgtm |
bc3a481
to
a26d375
Compare
a26d375
to
9b42163
Compare
Signed-off-by: fossedihelm <[email protected]>
9b42163
to
ea80d52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold to let others chime in, feel free to remove when we are good to go with this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- [ ] Mandatory pre-submit lanes. | ||
- [ ] Non-standard lanes (i.e. migrations, multus, ipv6) have been bumped by stakeholders. | ||
- [ ] Begin casual observation of issues, CI signal, test flakes, and critical PRs. | ||
- [ ] Notify SIGs and about upcoming Code Freeze Deadline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point we could enforce merge of specific PRs only with a change to the tide configuration for kubevirt/kubevirt.
As an example kubernetes/kubernetes also does it by only allowing PRs with a specific milestone attached to merge: https://github.com/kubernetes/test-infra/pull/35171/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be good. Thanks Daniel
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: