Skip to content

Conversation

fossedihelm
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

none

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 23, 2025
@kubevirt-bot kubevirt-bot requested review from dhiller and xpivarc July 23, 2025 10:07
@fossedihelm
Copy link
Contributor Author

fossedihelm commented Jul 23, 2025

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate having the lane bump as a separate action item.

Also the stabilization should be done per SIG, probably a check as reminder will help.

@Sreeja1725
Copy link

@fossedihelm we can also add an action-item to create a new release directory under api testdata during the code-freeze.
By following these steps - https://github.com/kubevirt/kubevirt/tree/main/staging/src/kubevirt.io/api/apitesting/testdata#populating-data-for-each-release

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably name the sigs that own the action items. WDYT?

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @fossedihelm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@fossedihelm
Copy link
Contributor Author

We should probably name the sigs that own the action items. WDYT?

@dhiller We can, but still not sure how, trying to keep the template lightweight. WDYT about a followup?

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@dhiller
Copy link
Contributor

dhiller commented Jul 28, 2025

We should probably name the sigs that own the action items. WDYT?

@dhiller We can, but still not sure how, trying to keep the template lightweight. WDYT about a followup?

Agree, let's capture that thought in a follow up and then we should be good to go.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold to let others chime in, feel free to remove when we are good to go with this.

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 31, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
- [ ] Mandatory pre-submit lanes.
- [ ] Non-standard lanes (i.e. migrations, multus, ipv6) have been bumped by stakeholders.
- [ ] Begin casual observation of issues, CI signal, test flakes, and critical PRs.
- [ ] Notify SIGs and about upcoming Code Freeze Deadline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we could enforce merge of specific PRs only with a change to the tide configuration for kubevirt/kubevirt.

As an example kubernetes/kubernetes also does it by only allowing PRs with a specific milestone attached to merge: https://github.com/kubernetes/test-infra/pull/35171/files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be good. Thanks Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants